Merge pull request #18374 from jcouv/features/tuple-names

Tuples get inferred element names

.github/PULL_REQUEST_TEMPLATE.md

@@ -0,0 +1,33 @@
+**Customer scenario**
+
+What does the customer do to get into this situation, and why do we think this
+is common enough to address for this release.  (Granted, sometimes this will be
+obvious "Open project, VS crashes" but in general, I need to understand how
+common a scenario is)
+
+**Bugs this fixes:**
+
+(either VSO or GitHub links)
+
+**Workarounds, if any**
+
+Also, why we think they are insufficient for RC vs. RC2, RC3, or RTW
+
+**Risk**
+
+This is generally a measure our how central the affected code is to adjacent
+scenarios and thus how likely your fix is to destabilize a broader area of code
+
+**Performance impact**
+
+(with a brief justification for that assessment (e.g. "Low perf impact because no extra allocations/no complexity changes" vs. "Low")
+
+**Is this a regression from a previous update?**
+
+**Root cause analysis:**
+
+How did we miss it?  What tests are we adding to guard against it in the future?
+
+**How was the bug found?**
+
+(E.g. customer reported it vs. ad hoc testing)

Roslyn.sln

@@ -1,7 +1,7 @@
 
 Microsoft Visual Studio Solution File, Format Version 12.00
 # Visual Studio 15
-VisualStudioVersion = 15.0.26228.9
+VisualStudioVersion = 15.0.26228.4
 MinimumVisualStudioVersion = 10.0.40219.1
 Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "CodeAnalysisTest", "src\Compilers\Core\CodeAnalysisTest\CodeAnalysisTest.csproj", "{A4C99B85-765C-4C65-9C2A-BB609AAB09E6}"
 EndProject

build/scripts/build-utils.ps1

@@ -12,13 +12,30 @@ $ErrorActionPreference="Stop"
 # 
 # Original sample came from: http://jameskovacs.com/2010/02/25/the-exec-problem/
 function Exec([scriptblock]$cmd, [string]$errorMessage = "Error executing command: " + $cmd) { 
+    # Clear LastExitCode before invoking the script so a windows command failure
+    # before doesn't carry over.  Can happen if the expression is pure powershell
+    # and not wrapping a windows command.
+    $lastexitcode = 0
+
     $output = & $cmd 
+
+    # Need to check both of these cases for errors as they represent different items
+    # - $?: did the powershell script block throw an error
+    # - $lastexitcode: did a windows command executed by the script block end in error
     if ((-not $?) -or ($lastexitcode -ne 0)) {
         Write-Host $output
         throw $errorMessage 
     } 
 }
 
+# Handy function for executing Invoke-Expression and reliably throwing an 
+# error if the expression, or the command it invoked, fails
+# 
+# Original sample came from: http://jameskovacs.com/2010/02/25/the-exec-problem/
+function Exec-Expression([string]$expr) {
+    Exec { Invoke-Expression $expr }
+}
+
 # Ensure that NuGet is installed and return the path to the 
 # executable to use.
 function Ensure-NuGet() {

build/scripts/build.ps1

@@ -33,12 +33,12 @@ function Run-Build() {
     $target = if ($project -ne "") { $project } else { Join-Path $repoDir "Roslyn.sln" }
     $buildArgs = "$buildArgs $target"
 
-    Invoke-Expression "& `"$msbuild`" $buildArgs"
+    Exec-Expression "& `"$msbuild`" $buildArgs"
 }
 
 function Run-Test() {
     $proj = Join-Path $repoDir "BuildAndTest.proj"
-    Invoke-Expression "& `"$msbuild`" /v:m /p:SkipCoreClr=true /t:Test $proj"
+    Exec-Expression "& `"$msbuild`" /v:m /p:SkipCoreClr=true /t:Test $proj"
 }
 
 try {

build/scripts/cibuild.ps1

@@ -108,7 +108,7 @@ try {
     Terminate-BuildProcesses
 
     if ($testDeterminism) {
-        Exec { & ".\build\scripts\test-determinism.ps1" $bootstrapDir }
+        Exec { & ".\build\scripts\test-determinism.ps1" -buildDir $bootstrapDir }
         Terminate-BuildProcesses
         exit 0
     }

build/scripts/create-perftests.ps1

@@ -1,32 +1,33 @@
 # Create the PerfTests directory under Binaries\$(Configuration).  There are still a number
 # of tools (in roslyn and roslyn-internal) that depend on this combined directory.
-param ([string]$script:binDir = $(throw "Need the binaries directory"))
-set-strictmode -version 2.0
+[CmdletBinding(PositionalBinding=$false)]
+param ([string]$buildDir)
+
+Set-StrictMode -version 2.0
 $ErrorActionPreference="Stop"
 
-try
-{
-    [string]$target = join-path $binDir "PerfTests"
-    write-host "PerfTests: $target"
+try {
+    . (Join-Path $PSScriptRoot "build-utils.ps1")
+    [string]$target = Join-Path $buildDir "PerfTests"
+    Write-Host "PerfTests: $target"
     if (-not (test-path $target)) {
-        mkdir $target | out-null
+        Create-Directory $target
     }
 
-    pushd $bindir
+    Push-Location $buildDir
     foreach ($subDir in @("Dlls", "UnitTests")) {
-        pushd $subDir
-        foreach ($path in gci -re -in "PerfTests") {
-            write-host "`tcopying $path"
-            copy -force -recurse "$path\*" $target
+        Push-Location $subDir
+        foreach ($path in Get-ChildItem -re -in "PerfTests") {
+            Write-Host "`tcopying $path"
+            Copy-Item -force -recurse "$path\*" $target
         }
-        popd
+        Pop-Location
     }
-    popd
+    Pop-Location
     exit 0
 }
-catch
-{
-    write-host "Error: $($_.Exception.Message)"
+catch {
+    Write-Host "Error: $($_.Exception.Message)"
     exit 1
 }
 

build/scripts/deploy-msbuild.ps1

@@ -17,7 +17,7 @@ try {
 
     Create-Directory $toolsDir
     Create-Directory $scratchDir
-    pushd $toolsDir
+    Push-Location $toolsDir
 
     $scratchFile = Join-Path $scratchDir "msbuild.txt"
     $scratchVersion = Get-Content -raw $scratchFile -ErrorAction SilentlyContinue
@@ -46,5 +46,5 @@ catch {
     exit 1
 }
 finally {
-    popd
+    Pop-Location
 }

build/scripts/generate-compiler-code.ps1

@@ -14,7 +14,7 @@ function Run-Tool($tool, $toolArgs) {
         throw "$tool does not exist"
     }
 
-    Invoke-Expression "& `"$coreRun`" `"$tool`" $toolArgs"
+    Exec-Expression "& `"$coreRun`" `"$tool`" $toolArgs"
     if ((-not $?) -or ($lastexitcode -ne 0)) {
         throw "Failed"
     }