Merge pull request #56189 from jasonmalinowski/allow-rename-with-references-in-generated-code

Don't try to rename references in source generated files

Author: jasonmalinowski

src/EditorFeatures/Test2/Rename/CSharp/SourceGeneratorTests.vb

@@ -33,6 +33,28 @@ public class GeneratedClass
             End Using
         End Sub
 
+        <Theory, CombinatorialData, Trait(Traits.Feature, Traits.Features.Rename)>
+        Public Sub RenameWithReferenceInGeneratedFile(host As RenameTestHost)
+            Using result = RenameEngineResult.Create(_outputHelper,
+                    <Workspace>
+                        <Project Language="C#" AssemblyName="ClassLibrary1" CommonReferences="true">
+                            <Document>
+public class [|$$RegularClass|]
+{
+}
+                            </Document>
+                            <DocumentFromSourceGenerator>
+public class GeneratedClass
+{
+    public void M(RegularClass c) { }
+}
+                            </DocumentFromSourceGenerator>
+                        </Project>
+                    </Workspace>, host:=host, renameTo:="A")
+
+            End Using
+        End Sub
+
         <Theory, CombinatorialData, Trait(Traits.Feature, Traits.Features.Rename)>
         <WorkItem(51537, "https://github.com/dotnet/roslyn/issues/51537")>
         Public Sub RenameWithCascadeIntoGeneratedFile(host As RenameTestHost)

src/Workspaces/Core/Portable/Rename/RenameLocation.ReferenceProcessing.cs

@@ -360,6 +360,13 @@ void AddRenameLocationIfNotGenerated(Location location, bool isRenamableAccessor
 
             internal static async Task<IEnumerable<RenameLocation>> GetRenamableReferenceLocationsAsync(ISymbol referencedSymbol, ISymbol originalSymbol, ReferenceLocation location, Solution solution, CancellationToken cancellationToken)
             {
+                // We won't try to update references in source generated files; we'll assume the generator will rerun
+                // and produce an updated document with the new name.
+                if (location.Document is SourceGeneratedDocument)
+                {
+                    return SpecializedCollections.EmptyEnumerable<RenameLocation>();
+                }
+
                 var shouldIncludeSymbol = await ShouldIncludeSymbolAsync(referencedSymbol, originalSymbol, solution, true, cancellationToken).ConfigureAwait(false);
                 if (!shouldIncludeSymbol)
                 {