Don't try to rename references in source generated files #56189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In afd8743, I prevented us from trying to rename the definition locations of a symbol that may have appeared in a generated file; that could happen in partial file cases or some cascading cases. But I missed the much simpler case: just having a good old fashioned reference in a generated file. This fixes that oversight. Fixes https://developercommunity.visualstudio.com/t/Renaming-fails-for-type-referenced-in-a-/1389855
ghost
added
the
jasonmalinowski
commented
Sep 3, 2021
| { | ||
| // We won't try to update references in source generated files; we'll assume the generator will rerun | ||
| // and produce an updated document with the new name. | ||
| if (location.Document is SourceGeneratedDocument) |
Member
Author
There was a problem hiding this comment.
We could update the underlying FAR engine to avoid even doing the search, but that's a fairly invasive change, and writing a custom collector from the streaming results would also work but is a bunch of extra work. Unless we're seeing performance issues, best to keep the fix simple.
davidwengier
approved these changes
Sep 4, 2021
jasonmalinowski
deleted the
allow-rename-with-references-in-generated-code
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In afd8743, I prevented us from trying to rename the definition locations of a symbol that may have appeared in a generated file; that could happen in partial file cases or some cascading cases. But I missed the much simpler case: just having a good old fashioned reference in a generated file. This fixes that oversight.
Fixes https://developercommunity.visualstudio.com/t/Renaming-fails-for-type-referenced-in-a-/1389855 and internal tracking AB#1393227.