Type parameters always match the argument type.

dotnet · Sep 27, 2017 · 3d943fe · 3d943fe
1 parent 244cca7
commit 3d943fe
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/src/EditorFeatures/CSharpTest/AddParameter/AddParameterTests.cs b/src/EditorFeatures/CSharpTest/AddParameter/AddParameterTests.cs
@@ -698,6 +698,7 @@ void M1()
 
         [WorkItem(21446, "https://github.com/dotnet/roslyn/issues/21446")]
         [Fact, Trait(Traits.Feature, Traits.Features.CodeActionsAddParameter)]
+        [Trait("TODO", "Fix broken")]
         public async Task TestInvocationLambda1()
         {
             await TestInRegularAndScriptAsync(
@@ -721,6 +722,7 @@ void M1()
         a(2);
     }
 }");
+            //Should be Action<int> a = (int v) => { };
         }
 
         [WorkItem(21446, "https://github.com/dotnet/roslyn/issues/21446")]
@@ -904,13 +906,13 @@ void M2()
 @"
 class C1
 {
-    void M1<T>(int v, T arg) { }
+    void M1<T>(T arg, int v) { }
     void M2()
     {
         M1(1, 2);
     }
 }");
-            //Should fix to either: void M1<T>(T arg, int v) { } or void M1<T>(T arg, T v) { }
+            //Should fix to: void M1<T>(T arg, T v) { }
         }
 
         [WorkItem(21446, "https://github.com/dotnet/roslyn/issues/21446")]
@@ -1129,7 +1131,7 @@ void M2()
 @"
 class C1
 {
-    void M1<T>(int v, T i) { }
+    void M1<T>(T i, bool v) { }
     void M2()
     {
         M1<int, bool>(1, true);

diff --git a/src/Features/Core/Portable/AddParameter/AbstractAddParameterCodeFixProvider.cs b/src/Features/Core/Portable/AddParameter/AbstractAddParameterCodeFixProvider.cs
@@ -557,6 +557,11 @@ private bool TypeInfoMatchesType(
                 return type.IsReferenceType || type.IsNullable();
             }
 
+            if (type.Kind == SymbolKind.TypeParameter)
+            {
+                return true;
+            }
+
             return false;
         }