Skip to content

Commit

Permalink
Remove PROTOTYPE comments (#61322)
Browse files Browse the repository at this point in the history
  • Loading branch information
AlekseyTs authored May 16, 2022
1 parent 42c7eab commit 8ecc45c
Showing 1 changed file with 1 addition and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ private static Verification Verify(bool isStatic)

private static bool Execute(bool isStatic, bool haveImplementationInDerivedInterface = false)
{
// PROTOTYPE(DefaultInterfaceImplementation) : Enable execution for isStatic and haveImplementationInDerivedInterface once runtime can handle it.
// https://github.com/dotnet/roslyn/issues/61321 : Enable execution for isStatic and haveImplementationInDerivedInterface once runtime can handle it.
if (!ExecutionConditionUtil.IsMonoOrCoreClr || (isStatic && haveImplementationInDerivedInterface))
{
return false;
Expand Down Expand Up @@ -34913,7 +34913,6 @@ static void Test<i11, i12>() where i11 : I1<string?> where i12 : I1<string>
}
else
{
// PROTOTYPE(DefaultInterfaceImplementation): Should we have similar warning for cast in the non-static scenario? Bug in nullability analysis?
compilation2.VerifyDiagnostics(
// (9,9): warning CS8631: The type 'Test1' cannot be used as type parameter 'i11' in the generic type or method 'Test1.Test<i11, i12>()'. Nullability of type argument 'Test1' doesn't match constraint type 'I1<string?>'.
// Test<Test1, Test1>();
Expand Down Expand Up @@ -35110,7 +35109,6 @@ static void Test<i11, i12>() where i11 : I1<string?> where i12 : I1<string>
}
else
{
// PROTOTYPE(DefaultInterfaceImplementation): Should we have similar warning for cast in the non-static scenario? Bug in nullability analysis?
compilation2.VerifyDiagnostics(
// (9,9): warning CS8631: The type 'Test1' cannot be used as type parameter 'i12' in the generic type or method 'Test1.Test<i11, i12>()'. Nullability of type argument 'Test1' doesn't match constraint type 'I1<string>'.
// Test<Test1, Test1>();
Expand Down

0 comments on commit 8ecc45c

Please sign in to comment.