Merge pull request #761 from jasonmalinowski/fix-memory-leaks

Mitigate memory leak and disable affected tests
dotnet · Feb 21, 2015 · 96f82a0 · 96f82a0
2 parents d100acf + 46a6a2e
commit 96f82a0
Show file tree

Hide file tree

Showing 8 changed files with 20 additions and 10 deletions.
diff --git a/src/Compilers/CSharp/Test/Semantic/Diagnostics/DiagnosticAnalyzerTests.AllInOne.cs b/src/Compilers/CSharp/Test/Semantic/Diagnostics/DiagnosticAnalyzerTests.AllInOne.cs
@@ -81,7 +81,8 @@ public class C
 
  #endregion
 
- [Fact]
+ [Fact(Skip = "GitHub Issue 759")]
+ [WorkItem(759)]
  public void AnalyzerDriverIsSafeAgainstAnalyzerExceptions()
  {
  var compilation = CreateCompilationWithMscorlib45(TestResource.AllInOneCSharpCode, parseOptions: TestOptions.Regular);

diff --git a/src/Compilers/Core/AnalyzerDriver/AnalyzerDriverHelper.cs b/src/Compilers/Core/AnalyzerDriver/AnalyzerDriverHelper.cs
@@ -508,7 +508,8 @@ internal static EventHandler<AnalyzerExceptionDiagnosticArgs> RegisterAnalyzerEx
  }
  };
 
- AnalyzerExceptionDiagnostic += handler;
+ // TODO: re-enable once bug 759 is fixed
+ // AnalyzerExceptionDiagnostic += handler;
  return handler;
  }
 
@@ -529,7 +530,8 @@ internal static EventHandler<AnalyzerExceptionDiagnosticArgs> RegisterAnalyzerEx
  }
  };
 
- AnalyzerExceptionDiagnostic += handler;
+ // TODO: re-enable once bug 759 is fixed
+ // AnalyzerExceptionDiagnostic += handler;
  return handler;
  }
 

diff --git a/src/Compilers/VisualBasic/Test/Semantic/Diagnostics/DiagnosticAnalyzerTests.AllInOne.vb b/src/Compilers/VisualBasic/Test/Semantic/Diagnostics/DiagnosticAnalyzerTests.AllInOne.vb
@@ -38,7 +38,8 @@ End Enum
  CreateCompilationWithMscorlib(source).VerifyAnalyzerDiagnostics({New BasicTrackingDiagnosticAnalyzer()})
  End Sub
 
- <Fact>
+ <Fact(Skip:="GitHub Issue 759")>
+ <WorkItem(759)>
  Public Sub AnalyzerDriverIsSafeAgainstAnalyzerExceptions()
  Dim compilation = CreateCompilationWithMscorlib({TestResource.AllInOneVisualBasicCode})
  ThrowingDiagnosticAnalyzer(Of SyntaxKind).VerifyAnalyzerEngineIsSafeAgainstExceptions(

diff --git a/src/Diagnostics/FxCop/Test/HardeningAnalyzer/HardeningAnalyzerTests.cs b/src/Diagnostics/FxCop/Test/HardeningAnalyzer/HardeningAnalyzerTests.cs
@@ -25,7 +25,8 @@ protected override DiagnosticAnalyzer GetCSharpDiagnosticAnalyzer()
  return new ExceptionThrowingSymbolAnalyzer_ThrowSymbolKindsOfInterest();
  }
 
- [Fact, Trait(Traits.Feature, Traits.Features.Diagnostics)]
+ [Fact(Skip = "GitHub Issue 759"), Trait(Traits.Feature, Traits.Features.Diagnostics)]
+ [WorkItem(759)]
  public void TestTypeParameterNamesCSharp()
  {
  var source = @"

diff --git a/...Features/CSharpTest/Diagnostics/DiagnosticAnalyzerDriver/DiagnosticAnalyzerDriverTests.cs b/...Features/CSharpTest/Diagnostics/DiagnosticAnalyzerDriver/DiagnosticAnalyzerDriverTests.cs
@@ -85,7 +85,8 @@ class C
  }
  }
 
- [Fact]
+ [Fact(Skip = "GitHub Issue 759")]
+ [WorkItem(759)]
  public void DiagnosticAnalyzerDriverIsSafeAgainstAnalyzerExceptions()
  {
  var source = TestResource.AllInOneCSharpCode;

diff --git a/src/EditorFeatures/Test2/Diagnostics/DiagnosticServiceTests.vb b/src/EditorFeatures/Test2/Diagnostics/DiagnosticServiceTests.vb
@@ -398,7 +398,8 @@ Namespace Microsoft.CodeAnalysis.Editor.Implementation.Diagnostics.UnitTests
  End Using
  End Sub
 
- <Fact, WorkItem(937915), Trait(Traits.Feature, Traits.Features.Diagnostics)>
+ <Fact(Skip:="GitHub Issue 759"), WorkItem(937915), Trait(Traits.Feature, Traits.Features.Diagnostics)>
+ <WorkItem(759)>
  Public Sub TestDiagnosticAnalyzerExceptionHandledGracefully2()
  Dim test = <Workspace>
  <Project Language="C#" CommonReferences="true">

diff --git a/...res/VisualBasicTest/Diagnostics/DiagnosticAnalyzerDriver/DiagnosticAnalyzerDriverTests.vb b/...res/VisualBasicTest/Diagnostics/DiagnosticAnalyzerDriver/DiagnosticAnalyzerDriverTests.vb
@@ -58,7 +58,8 @@ End Class
  End Using
  End Sub
 
- <Fact>
+ <Fact(Skip:="GitHub Issue 759")>
+ <WorkItem(759)>
  Public Sub DiagnosticAnalyzerDriverIsSafeAgainstAnalyzerExceptions()
  Dim source = TestResource.AllInOneVisualBasicCode
  Using Workspace = VisualBasicWorkspaceFactory.CreateWorkspaceFromFile(source)

diff --git a/src/Features/Core/Diagnostics/AbstractHostDiagnosticUpdateSource_Registration.cs b/src/Features/Core/Diagnostics/AbstractHostDiagnosticUpdateSource_Registration.cs
@@ -12,13 +12,15 @@ internal abstract partial class AbstractHostDiagnosticUpdateSource
  protected AbstractHostDiagnosticUpdateSource()
  {
  // Register for exception diagnostics from workspace's analyzer manager.
- AnalyzerExceptionDiagnostic += OnAnalyzerExceptionDiagnostic;
+ // TODO: re-enable once bug 759 is fixed
+ // AnalyzerExceptionDiagnostic += OnAnalyzerExceptionDiagnostic;
  }
 
  ~AbstractHostDiagnosticUpdateSource()
  {
  // Unregister for exception diagnostics from workspace's analyzer manager.
- AnalyzerExceptionDiagnostic -= OnAnalyzerExceptionDiagnostic;
+ // TODO: re-enable once bug 759 is fixed
+ // AnalyzerExceptionDiagnostic -= OnAnalyzerExceptionDiagnostic;
  }
 
  internal static EventHandler<AnalyzerExceptionDiagnosticArgs> RegisterAnalyzerExceptionDiagnosticHandler(ImmutableArray<DiagnosticAnalyzer> analyzers, Workspace workspace)