Skip to content

Commit

Permalink
Merge pull request #12107 from jasonmalinowski/remove-update-1-workar…
Browse files Browse the repository at this point in the history
…ound

Remove workaround for lack of #7812
  • Loading branch information
jasonmalinowski authored Jun 23, 2016
2 parents 4db8204 + b5e9775 commit 9b31cdd
Showing 1 changed file with 0 additions and 13 deletions.
13 changes: 0 additions & 13 deletions build/Targets/VSL.Imports.targets
Original file line number Diff line number Diff line change
Expand Up @@ -103,19 +103,6 @@
</When>
</Choose>

<!-- Because https://github.com/dotnet/roslyn/issues/7812 is not yet fixed, the IDE doesn't know if we set the PublicSign
flag. As a result, all design-time builds will thing we're real-signing, which causes semantics to get all screwed up.
The workaround for now is, for design-time builds only, to pass the DelaySign flag since that's "good enough". This
must be done in a target versus conditioning on BuildingProject, since BuildingProject itself is correctly set in a
target. -->
<Target Name="FixPublicSignFlagForDesignTimeBuilds" BeforeTargets="CoreCompile" Condition="'$(PublicSign)' == 'true'">
<PropertyGroup Condition="'$(BuildingProject)' == 'false'">
<!-- Turn off PublicSign, because leaving both to true will make the Csc task unhappy -->
<PublicSign>false</PublicSign>
<DelaySign>true</DelaySign>
</PropertyGroup>
</Target>

<!-- ====================================================================================
Generation of binding redirects.
Expand Down

0 comments on commit 9b31cdd

Please sign in to comment.