Fix binding for checkbox text in rename dialogs (#61430)

Previously text was bound to properties on the control type using x:Name. This restores that
dotnet · May 20, 2022 · af1f72e · af1f72e
1 parent 92ebb62
commit af1f72e
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/src/EditorFeatures/Core.Wpf/InlineRename/UI/Adornment/RenameFlyout.xaml b/src/EditorFeatures/Core.Wpf/InlineRename/UI/Adornment/RenameFlyout.xaml
@@ -16,6 +16,7 @@
              GotKeyboardFocus="Adornment_GotKeyboardFocus"
              Focusable="False"
              UseLayoutRounding="True"
+             x:Name="control"
              Background="{DynamicResource {x:Static rename:InlineRenameColors.BackgroundBrushKey}}">
 
     <UserControl.Resources>

diff --git a/src/EditorFeatures/Core.Wpf/InlineRename/UI/Dashboard/RenameDashboard.xaml b/src/EditorFeatures/Core.Wpf/InlineRename/UI/Dashboard/RenameDashboard.xaml
@@ -11,6 +11,7 @@
              MinWidth="300"
              Cursor="Arrow"
              Focusable="True"
+             x:Name="dashboard"
              AutomationProperties.AutomationId="Microsoft.CodeAnalysis.EditorFeatures.InlineRenameDialog" 
              UseLayoutRounding="True">
     <!-- 

diff --git a/src/EditorFeatures/Core.Wpf/InlineRename/UI/InlineRenameAdornment.cs b/src/EditorFeatures/Core.Wpf/InlineRename/UI/InlineRenameAdornment.cs
@@ -11,8 +11,12 @@
 
 namespace Microsoft.CodeAnalysis.Editor.Implementation.InlineRename
 {
-    internal abstract class InlineRenameAdornment : UserControl, IDisposable
+    /// <summary>
+    /// A base class for rename controls. Needs to have a default constructor so the 
+    /// type can be used in ResourceDictionaries in XAML
+    /// </summary>
+    internal class InlineRenameAdornment : UserControl, IDisposable
     {
-        public abstract void Dispose();
+        public virtual void Dispose() { }
     }
 }