fix Inline temporary variable adds unnecessary cast (#70423)

dotnet · Nov 23, 2024 · bb7610d · bb7610d
2 parents c2deeae + dc54192
commit bb7610d
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 2 deletions.
diff --git a/...Sharp/Portable/CodeRefactorings/InlineTemporary/InlineTemporaryCodeRefactoringProvider.cs b/...Sharp/Portable/CodeRefactorings/InlineTemporary/InlineTemporaryCodeRefactoringProvider.cs
@@ -408,10 +408,14 @@ ExpressionSyntax CreateExpressionToInline()
 
                 return SyntaxFactory.ArrayCreationExpression(arrayType, arrayInitializer);
             }
-            else if (isVar && expression is ObjectCreationExpressionSyntax or ArrayCreationExpressionSyntax or CastExpressionSyntax)
+            else if (isVar && expression is
+                        ObjectCreationExpressionSyntax or
+                        ArrayCreationExpressionSyntax or
+                        CastExpressionSyntax or
+                        InvocationExpressionSyntax)
             {
                 // if we have `var x = new Y();` there's no need to do any casting as the type is indicated
-                // directly in the existing code.  The same holds for `new Y[]` or `(Y)...`
+                // directly in the existing code.  The same holds for `new Y[]` or `(Y)...` or `Y(...)`
                 return expression;
             }
             else

diff --git a/src/Features/CSharpTest/InlineTemporary/InlineTemporaryTests.cs b/src/Features/CSharpTest/InlineTemporary/InlineTemporaryTests.cs
@@ -5884,4 +5884,31 @@ public string M()
 
         await TestInRegularAndScriptAsync(code, expected);
     }
+
+    [Fact, WorkItem("https://github.com/dotnet/roslyn/issues/69869")]
+    public async Task InlineTemporaryNoNeededVariable()
+    {
+        await TestInRegularAndScriptAsync(
+            """
+            using System;
+            class A
+            {
+                void M(string[] args)
+                {
+                    var [||]a = Math.Round(1.1D);
+                    var b = a;
+                }
+            }
+            """,
+            """
+            using System;
+            class A
+            {
+                void M(string[] args)
+                {
+                    var b = Math.Round(1.1D);
+                }
+            }
+            """);
+    }
 }