Skip to content

Commit

Permalink
Merge pull request #49832 from dotnet/revert-49790-env
Browse files Browse the repository at this point in the history
Revert "Increase CoreCLR dump information"
  • Loading branch information
msftbot[bot] authored Dec 7, 2020
2 parents 4faa3b3 + 28862da commit d3e810f
Showing 1 changed file with 0 additions and 19 deletions.
19 changes: 0 additions & 19 deletions src/Tools/Source/RunTests/ProcessTestExecutor.cs
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
using System.Collections.Immutable;
using System.IO;
using System.Linq;
using System.Runtime.InteropServices;
using System.Text;
using System.Threading;
using System.Threading.Tasks;
Expand Down Expand Up @@ -121,7 +120,6 @@ private async Task<TestResult> RunTestAsyncInternal(AssemblyInfo assemblyInfo, b
// Define environment variables for processes started via ProcessRunner.
var environmentVariables = new Dictionary<string, string>();
Options.ProcDumpInfo?.WriteEnvironmentVariables(environmentVariables);
MaybeAddStressEnvironmentVariables();

if (retry && File.Exists(resultsFilePath))
{
Expand Down Expand Up @@ -218,23 +216,6 @@ private async Task<TestResult> RunTestAsyncInternal(AssemblyInfo assemblyInfo, b
testResultInfo,
commandLineArguments,
processResults: ImmutableArray.CreateRange(processResultList));

void MaybeAddStressEnvironmentVariables()
{
#if NETCOREAPP
// These environment variables will generate better dump information for the runtime team
// that will help them track down a GC issue that is impacting ConcurrentDictionary
// https://github.com/dotnet/runtime/issues/45557
if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
{
environmentVariables.Add("COMPlus_StressLog", "1");
environmentVariables.Add("COMPlus_LogLevel", "6");
environmentVariables.Add("COMPlus_LogFacility", "0x00080001");
environmentVariables.Add("COMPlus_StressLogSize", "2000000");
environmentVariables.Add("COMPlus_TotalStressLogSize", "40000000");
}
}
#endif
}
catch (Exception ex)
{
Expand Down

0 comments on commit d3e810f

Please sign in to comment.