Removes calls to NotifyOfCrossThreadDependency.

The underlying debugger issue has been fixed, so the calls are not needed anymore. (changeset 1274269)
dotnet · Jun 20, 2014 · db7c3c7 · db7c3c7
1 parent e68ce06
commit db7c3c7
Show file tree

Hide file tree

Showing 5 changed files with 0 additions and 41 deletions.
diff --git a/Src/Compilers/CSharp/Source/Syntax/InternalSyntax/SyntaxNode.cs b/Src/Compilers/CSharp/Source/Syntax/InternalSyntax/SyntaxNode.cs
@@ -377,8 +377,6 @@ public override SyntaxNode GetStructure(Microsoft.CodeAnalysis.SyntaxTrivia triv
                 var parent = trivia.Token.Parent;
                 if (parent != null)
                 {
-                    DebuggerUtilities.CallBeforeAcquiringLock(); //see method comment
-
                     SyntaxNode structure;
                     var structsInParent = structuresTable.GetOrCreateValue(parent);
                     lock (structsInParent)

diff --git a/Src/Compilers/Core/Source/CodeAnalysis.csproj b/Src/Compilers/Core/Source/CodeAnalysis.csproj
@@ -225,7 +225,6 @@
     <Compile Include="InternalUtilities\ConcurrentLruCache.cs" />
     <Compile Include="InternalUtilities\ConcurrentSet.cs" />
     <Compile Include="InternalUtilities\ConsList`1.cs" />
-    <Compile Include="InternalUtilities\DebuggerUtilities.cs" />
     <Compile Include="InternalUtilities\DecimalUtilities.cs" />
     <Compile Include="InternalUtilities\DocumentationCommentXmlNames.cs" />
     <Compile Include="InternalUtilities\EnumerableExtensions.ComparisonComparer.cs" />

diff --git a/Src/Compilers/Core/Source/CodeGen/PrivateImplementationDetails.cs b/Src/Compilers/Core/Source/CodeGen/PrivateImplementationDetails.cs
@@ -104,8 +104,6 @@ internal Cci.IFieldReference CreateDataField(byte[] data)
 
             Cci.ITypeReference type = this.proxyTypes.GetOrAdd((uint)data.Length, size => GetStorageStruct(size));
 
-            DebuggerUtilities.CallBeforeAcquiringLock(); //see method comment
-
             var block = new MetadataBlock(data);
 
             //This object may be accessed concurrently

diff --git a/Src/Compilers/Core/Source/InternalUtilities/DebuggerUtilities.cs b/Src/Compilers/Core/Source/InternalUtilities/DebuggerUtilities.cs
diff --git a/Src/Compilers/Core/Source/NonPortable/MetadataCache.cs b/Src/Compilers/Core/Source/NonPortable/MetadataCache.cs
@@ -186,7 +186,6 @@ private static void CompactCache(Object state)
 
                 compactCollectionCount = currentCollectionCount;
 
-                DebuggerUtilities.CallBeforeAcquiringLock(); //see method comment
                 lock (Guard)
                 {
                     if (!(AnyAssembliesCached() || AnyModulesCached() || AnyAnalyzerAssembliesCached()))
@@ -268,8 +267,6 @@ internal static void TriggerCacheCompact()
         /// </summary>
         private static void CompactCacheOfAssemblies()
         {
-            DebuggerUtilities.CallBeforeAcquiringLock(); //see method comment
-
             // Do one pass through the assemblyKeys list    
             int originalCount = -1;
 
@@ -335,8 +332,6 @@ private static bool AnyAssembliesCached()
         /// </summary>
         private static void CompactCacheOfModules()
         {
-            DebuggerUtilities.CallBeforeAcquiringLock(); //see method comment
-
             // Do one pass through the moduleKeys list    
             int originalCount = -1;
 
@@ -402,8 +397,6 @@ private static bool AnyModulesCached()
         /// </summary>
         private static void CompactCacheOfAnalyzers()
         {
-            DebuggerUtilities.CallBeforeAcquiringLock(); //see method comment
-
             // Do one pass through the analyzerAssemblyKeys list    
             int originalCount = -1;