Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests needed for out variables in declarators in for loop. #13459

Closed
gafter opened this issue Aug 30, 2016 · 1 comment
Closed

Tests needed for out variables in declarators in for loop. #13459

gafter opened this issue Aug 30, 2016 · 1 comment
Assignees
@AlekseyTs
Labels
Area-Compilers Bug New Language Feature - Out Variable Declaration Out Variable Declaration New Language Feature - Pattern Matching Pattern Matching
Milestone
2.0 (Preview 5)

Comments

@gafter
Copy link
Member

gafter commented Aug 30, 2016 •
edited
Loading

In #13274 (comment) @AlekseyTs asked about test coverage for the error case of out variables and pattern variables (illegally) declared in declarators in a for loop. We should ensure we have such tests to ensure the compiler behavior is sane.

See also #13274 (comment)
@gafter gafter added this to the 2.0 (RC) milestone Aug 30, 2016
@gafter gafter mentioned this issue Aug 30, 2016
Merged
@AlekseyTs AlekseyTs added Bug and removed Test Test failures in roslyn-CI labels Aug 31, 2016
@AlekseyTs
Copy link
Contributor

I think there is actually a bug in this scenario.

@AlekseyTs AlekseyTs modified the milestones: 2.0 (Preview 5), 2.0 (RC) Aug 31, 2016
@AlekseyTs AlekseyTs self-assigned this Aug 31, 2016
AlekseyTs added a commit to AlekseyTs/roslyn that referenced this issue Sep 1, 2016
@AlekseyTs
Properly handle expression variable declared within VariableDeclarato…
f0304e0 
…rSyntax.ArgumentList in ‘fixed’, ‘for’ and ‘using’ statements.

Related to dotnet#12597.
Fixes dotnet#13459, dotnet#13460.
@AlekseyTs AlekseyTs mentioned this issue Sep 1, 2016
Merged
@AlekseyTs AlekseyTs added 4 - In Review A fix for the issue is submitted for review. and removed 3 - Working labels Sep 1, 2016
@AndyGerlicher AndyGerlicher removed 4 - In Review A fix for the issue is submitted for review. Bug labels Sep 2, 2016
@AlekseyTs AlekseyTs added the Bug label Sep 7, 2016
@gafter gafter mentioned this issue Sep 8, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlekseyTs AlekseyTs

Labels
Area-Compilers Bug New Language Feature - Out Variable Declaration Out Variable Declaration New Language Feature - Pattern Matching Pattern Matching
Projects
None yet
Milestone
2.0 (Preview 5)
Development

No branches or pull requests
3 participants
@gafter @AndyGerlicher @AlekseyTs