Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to disable Go To Implementation feature in Roslyn API #15958

Closed
dungpa opened this issue Dec 16, 2016 · 8 comments
Closed

Add an option to disable Go To Implementation feature in Roslyn API #15958

dungpa opened this issue Dec 16, 2016 · 8 comments
Assignees
Milestone

Comments

@dungpa
Copy link

dungpa commented Dec 16, 2016

Version Used:
Microsoft.CodeAnalysis.EditorFeatures 2.0.0-rc2

Steps to Reproduce:
F# language service in Visual Studio 2017 starts using Roslyn for editor features:

  1. Open an F# file in Visual Studio
  2. Right click and choose Go To Implementation
  3. Nothing happens

Expected Behavior:
One should be able to opt-out and disable Go To Implementation if F# language service doesn't know how to implement Go To Implementation yet.

Actual Behavior:
There is no API in order to hide Go To Implementation feature.

See dotnet/fsharp#1800 (comment) for more details.

@CyrusNajmabadi
Copy link
Member

Anything other than GoToImpl?

@dungpa
Copy link
Author

dungpa commented Dec 16, 2016

Probably also 'Quick Actions and Refactoring (Ctrl + .)' feature if there is not a way to disable that yet.

@CyrusNajmabadi
Copy link
Member

Probably also 'Quick Actions and Refactoring (Ctrl + .)' feature

Hrmm... intersting. will have to look into that. That feature isn't controlled by us.

@CyrusNajmabadi
Copy link
Member

Ok, i have a fix out for the 'quick actions' menu item. Anything else?

@dungpa
Copy link
Author

dungpa commented Dec 16, 2016

After checking other menu items, I think that's all for now. Thanks for the quick turn around.

@CyrusNajmabadi
Copy link
Member

Ok, you should no longer see "Quick Actions and Refactorings". If/when F# adds support for that, we can make it work by exporting the right set of Languages on SuggestedActionSourceProvider.

@dungpa
Copy link
Author

dungpa commented Dec 19, 2016

Great, thanks.

CyrusNajmabadi added a commit that referenced this issue Dec 19, 2016
Add per language options to disable GoToDef and GoToImpl.

Fixes #15958
@saul
Copy link
Contributor

saul commented Dec 31, 2016

@dungpa, @CyrusNajmabadi - not sure "Quick Actions and Refactorings" has been disabled? We now have a few code fixes that use this feature I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants