Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to implement semantic info APIs for tuple literals in VB #16697

Open
VSadov opened this issue Jan 23, 2017 · 2 comments
Open

Need to implement semantic info APIs for tuple literals in VB #16697

VSadov opened this issue Jan 23, 2017 · 2 comments
Labels
Area-Compilers Bug Concept-API This issue involves adding, removing, clarification, or modification of an API. Feature - Tuples Tuples Language-VB
Milestone
Backlog

Comments

@VSadov
Copy link
Member

VSadov commented Jan 23, 2017

Same as in #14600 , but for VB.
@VSadov VSadov added Area-Compilers Bug Concept-API This issue involves adding, removing, clarification, or modification of an API. Language-VB Feature - Tuples Tuples labels Jan 23, 2017
@VSadov VSadov added this to the 2.1 milestone Jan 23, 2017
@VSadov VSadov mentioned this issue Jan 23, 2017
Merged
VSadov added a commit to VSadov/roslyn that referenced this issue Feb 2, 2017
@VSadov
CodeCleanup should not try adding "()" to tuple element names.
505857b 
Fixes  dotnet#16781

Becasue of the another bug, dotnet#16697, it is possible that tuple element names would bind to methods. That will require a bigger fix.

But regrdless of that, the CodeCleanup should not try adding "()" to tuple names. No need to consult with semantic info (which is fairly expensive), when this will never be a right thing to do. It does not fit the syntax model and crashes with invalid cast exception.
@VSadov VSadov mentioned this issue Feb 2, 2017
Closed
@jaredpar jaredpar modified the milestones: 15.3, 15.1 Mar 9, 2017
@jcouv
Copy link
Member

jcouv commented Apr 22, 2017

Seems like this will be blocking the refactorings on tuples with inferred name. Currently, GetSymbolInfo on i in (i:=1, 2) returns the local named i, not the tuple field.
Had you figured out some high-level design for making this work in VB?

This was referenced Apr 23, 2017
Merged
Closed
Merged
@jcouv jcouv mentioned this issue May 8, 2017
Merged
@jcouv
Copy link
Member

jcouv commented May 8, 2017

Whenever this gets fixed, please make sure to un-skip tests that reference this issue, such as this one:

        <Fact(Skip:="InvalidCastException"), Trait(Traits.Feature, Traits.Features.CodeActionsInlineTemporary)>
        <WorkItem(16697, "https://github.com/dotnet/roslyn/issues/16697")>
        Public Async Function TupleElementNameIsNotReplaced() As Task

@jaredpar jaredpar modified the milestones: 15.3, 15.later May 15, 2017
@jaredpar jaredpar modified the milestones: 15.6, 16.0 Jan 5, 2018
@jinujoseph jinujoseph modified the milestones: 16.0, 16.3 Jun 9, 2019
@jcouv jcouv modified the milestones: 16.3, Compiler.Next Jul 8, 2019
@jaredpar jaredpar removed this from the Compiler.Next milestone Sep 12, 2023
@jaredpar jaredpar added this to the Backlog milestone Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Compilers Bug Concept-API This issue involves adding, removing, clarification, or modification of an API. Feature - Tuples Tuples Language-VB
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
4 participants
@jaredpar @VSadov @jinujoseph @jcouv