Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IConversionExpression must expose IsChecked boolean #18055

Closed
mavasani opened this issue Mar 22, 2017 · 3 comments
Closed

IConversionExpression must expose IsChecked boolean #18055

mavasani opened this issue Mar 22, 2017 · 3 comments
Assignees
Labels
4 - In Review A fix for the issue is submitted for review. Area-Analyzers Bug Concept-API This issue involves adding, removing, clarification, or modification of an API. Feature - IOperation IOperation Urgency-Soon
Milestone

Comments

@mavasani
Copy link
Contributor

mavasani commented Mar 22, 2017

BoundConversion nodes in both compilers have this flag. We should expose this flag on IConversionExpression.

@mavasani mavasani added Bug Concept-API This issue involves adding, removing, clarification, or modification of an API. Feature - IOperation IOperation labels Mar 22, 2017
@mavasani mavasani added this to the 15.3 milestone Mar 22, 2017
@mavasani
Copy link
Contributor Author

Tag @dotnet/analyzer-ioperation

@CyrusNajmabadi
Copy link
Member

CyrusNajmabadi commented Apr 13, 2017

Design Team Notes

We agree that this needs to done.

@jinujoseph jinujoseph modified the milestones: 15.6, 15.3 May 8, 2017
@jinujoseph jinujoseph modified the milestones: 15.3, 15.6 Jun 8, 2017
@jinujoseph jinujoseph modified the milestones: 15.5, 15.3 Jun 22, 2017
@jinujoseph jinujoseph added 4 - In Review A fix for the issue is submitted for review. and removed 3 - Working labels Aug 8, 2017
@333fred
Copy link
Member

333fred commented Aug 11, 2017

Fixed in #21040.

@333fred 333fred closed this as completed Aug 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - In Review A fix for the issue is submitted for review. Area-Analyzers Bug Concept-API This issue involves adding, removing, clarification, or modification of an API. Feature - IOperation IOperation Urgency-Soon
Projects
None yet
Development

No branches or pull requests

5 participants