[IOperation] API/Design Review

[jinujoseph]

V1

Checked: Review Complete
Bold : Active Work
Grey : Task Completed

• Refactor & Decide on interface versus abstract type #18246: Refactor & Decide on interface versus abstract type (Decision on interface/class pending)

• IOperation: A proposal to change design around IHasArgumentsExpression, IInvocationExpression and IArgument interfaces. #8813 IHasArgumentsExpression, IInvocationExpression and IArgument interfaces , implementation pending IHasArgumentsExpression.ArgumentsInEvaluationOrder in C# should not use private implementation #18549

• IObjectCreationExpression API shape #18115: IObjectCreationExpression API shape

• IInvalidExpression and IInvalidStatement should expose child operations #17802: IInvalidExpression and IInvalidStatement should expose child operations

• [IOperation] Should As New initializers be the same node? #18335 Should the initializers of an As New multiple declaration be the same object

• IOperation: BoundLambda - value returned by IOperation.Type property might be inconsistent across languages #8851 BoundLambda - value returned by IOperation.Type

• IOperation doesn't support string interpolations #18300 IOperation API for string interpolation

• Feature request: IOperation support for queries #17838: Discuss IOperation API for queries

• IArrayCreationExpression.Dimensions for explicit versus implicit case #18155: IArrayCreationExpression.Dimensions for explicit versus implicit case

• Remove IUnboundLambda #18057 IUnboundLambdaExpression should not be part of APIs

• IIncrementExpression exposes both UnaryOperatorKind and BinaryOperatorKind #18056 IIncrementExpression

• IConversionExpression must expose IsChecked boolean #18055 IConversionExpression must expose IsChecked boolean

• There is no way to get UnaryOperationKind.OperatorMethodFalse and no node to map to IUnaryOperatorExpression in IIfStatement #18135 true/false unary operation

• Semantics of IOperation.IsInvalid #18089, IOperation: VB - BoundObjectCreationExpression.FieldInitializer/PropertyInitializer, implementation of IsInvalid should probably also check HasErrors on the corresponding BoundAssignmentOperator #8885 Semantics of IOperation.IsInvalid

• [IOperation] GetOperation returns a superset of IOperations for given syntax nodes #18064 GetOperation returns a superset of IOperations

• Implement Ioperation Parent pointer #18601 Parent Pointer

• Remove ConditionalWeakTable from the compilers #9331 Remove ConditionalWeakTable from the compilers

• IOperation API shape for object and collection initializer expressions #18781 IOperation: It looks like collection initializers and some forms of member initializers cannot be represented by IObjectCreationExpression #8883 IOperation API shape for collection initializer expressions

• Implement IOperation support for tuple literals #10856: IOperation support for tuple literals

• IOperation API for BoundUserDefinedConditionalLogicalOperator #19925: IOperation API for BoundUserDefinedConditionalLogicalOperator

• IOperation API for anonymous object creation expressions #19926: IOperation API for anonymous object creation expressions

• IOperation API for nameof expression #19954: IOperation API for nameof expression

• OperationKind.FieldInitializerInCreation and OperationKind.PropertyInitializerInCreation are redundant #19300: OperationKind.FieldInitializerInCreation and OperationKind.PropertyInitializerInCreation are redundant

• IOperation API shape for DelegateCreationExpression #18839 IOperation: VB - It doesn't feel appropriate for BoundDelegateCreationExpression to implement IMethodBindingExpression #8897: IOperation API shape for DelegateCreationExpression

• IOperation: VB - need to figure out what is the right way to expose various Bound...Placeholder nodes #8905, InConversion and OutConversion of VB ByRef argument exposes placeholder nodes as IOperations #18548 Bound...Placeholder nodes

• IExpression and IStatement (and IExpressionStatement and IStatementExpression).

• Operand of the IUnaryOperatorExpression doesn't implement any specific IOperation #18289 IOperation: It looks like some unary operator semantics cannot be represented via IUnaryOperatorExpression  #8825 IOperation: It looks like some unary operator semantics cannot be represented via IUnaryOperatorExpression  #8825 Operand of the IUnaryOperatorExpression

• IOperation: VB - BoundLateAddressOfOperator should implement specific interface #8917 IOperation: VB - BoundLateInvocation should implement specific interface #8916 IOperation: VB - BoundAttribute should either implement specific interface or throw from all IOperation members. #8915 IOperation: VB - BoundMethodGroup should implement specific interface #8914 IOperation: VB - BoundAddressOfOperator should implement specific interface #8913 VB missing interface

• IOperation: It looks like there is no way to get conditional access receiver for IConditionalAccessExpression #8861 receiver for IConditionalAccessExpression

• IOperation: There is no way to get to conversion applied to the Primary expression of INullCoalescingExpression #8852 Primary expression of INullCoalescingExpression

• IOperation Analyzers and Fields #18915 Analyzers & Fields

• [IOperation] Multiple Variable declaration inconsistency #18000 Multiple Variable Declaration

• [IOperation] Differing variable declaration in Blocks loops between C# and VB #17998 Block Loops vb vs c#

• IOperations do not expose the BoundCall to the chained constructor in the IBlock for a constructor. #11859 BoundCall - constructor

• Default argument operation doesn't handle caller info attributes #7960 argument operation doesn't handle caller info attributes

• IOperation support for arglist operator #19949: IOperation support for arglist operator

• IOperation API for BoundPointerElementAccesss #19960: IOperation API for BoundPointerElementAccesss

• IOperation - IOperation API for BoundMethodGroup and BoundPropertyGroup #19965: IOperation - IOperation API for MemberGroups

• IOperation API for BoundDeconstructionAssignmentOperator #19924: IOperation API for BoundDeconstructionAssignmentOperator

• IOperation support for patterns #19927: IOperation support for patterns

• IBoundDelegateCreationExpression API #20095 IMethodBindingExpression missing IConversionExpressions

• IConversionExpression Rework #20046 IConversion support for InterpolatedString->IFormattable

• Operation tree contains no nodes for local functions #19902 Operation tree contains no nodes for local functions

• https://github.com/dotnet/roslyn/issues?q=is%3Aopen+is%3Aissue+label%3A%22New+Feature+-+IOperation%22+label%3ADiscussion

V2

• IOperation API for attributes #18198: IOperation API for attributes
• [IOperation] Hidden sub nodes #18351 Hidden sub nodes of valid syntax
• Should __arglist, __makeref, __refvalue, __reftype have public IOperation nodes? #8394 __arglist, __makeref, __refvalue, __reftype
• IOperation representational issues when raising IL #8640 IOperation representational issues when raising IL

[jinujoseph]

@dotnet/analyzer-ioperation

[jinujoseph]

we have individual items tracking