-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement IOperation support for tuple literals #10856
Labels
4 - In Review
A fix for the issue is submitted for review.
Area-Analyzers
Bug
Feature - IOperation
IOperation
Feature - Tuples
Tuples
Language-C#
Urgency-Soon
Milestone
Comments
Possible API shape:
Points to discuss:
|
mavasani
added a commit
that referenced
this issue
May 18, 2017
Fixes #10856 ``` public interface ITupleExpression : IOperation { /// <summary> /// Elements for tuple expression. /// </summary> ImmutableArray<IOperation> Elements { get; } } ```
Adding some design issues raised by Aleksey in the PR to implement this:
|
Design Team Discussion Keep tuple tests with semantic model tests around tuples. |
This was referenced Jul 10, 2017
Fixed with #20749 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
4 - In Review
A fix for the issue is submitted for review.
Area-Analyzers
Bug
Feature - IOperation
IOperation
Feature - Tuples
Tuples
Language-C#
Urgency-Soon
Design and implement IOperation support for tuple literals.
Current implementation intentionally implements this as OperationKind.None
The right alternative seems to be introducing a specific operation kind and make visitor visit all the arguments of the literal.
Alternatively we may make tuple literals look like ObjectCreation (which it is indirectly), but it does not feel right conceptually.
The text was updated successfully, but these errors were encountered: