Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOperation API for BoundUserDefinedConditionalLogicalOperator #19925

Open
mavasani opened this issue May 31, 2017 · 4 comments
Open

IOperation API for BoundUserDefinedConditionalLogicalOperator #19925

mavasani opened this issue May 31, 2017 · 4 comments
Labels
Area-Analyzers Bug Concept-API This issue involves adding, removing, clarification, or modification of an API. Feature - IOperation IOperation _Product-level triaged
Milestone

Comments

@mavasani
Copy link
Contributor

Proposed:

    public interface IUserDefinedConditionalLogicalOperatorExpression : IOperation
    {
        AssignmentInfo AssignmentInfo { get; }
        IMethodSymbol LogicalOperator { get; }
        IMethodSymbol TrueOperator { get; }
        IMethodSymbol FalseOperator { get; }
    }
@mavasani mavasani added Area-Analyzers Bug Concept-API This issue involves adding, removing, clarification, or modification of an API. Discussion Feature - IOperation IOperation labels May 31, 2017
@mavasani mavasani added this to the 15.later milestone May 31, 2017
@CyrusNajmabadi
Copy link
Member

CyrusNajmabadi commented Jun 1, 2017

Design Team Decision

Remove: AssignmentInfo AssignmentInfo { get; }

We want to just have "IBinaryOperatorExpression". Explore idea of exposing the true/false operators either directly on this type, or maybe through a 'ShortcircuitingInfo' type.

@jinujoseph jinujoseph modified the milestones: 15.6, 15.later Jun 8, 2017
@jinujoseph jinujoseph assigned mavasani and unassigned 333fred Aug 1, 2017
@tmat
Copy link
Member

tmat commented Sep 6, 2017

Check if there is API that needs to be made internal.

@mavasani
Copy link
Contributor Author

mavasani commented Sep 7, 2017

We do not have any API currently, moving out to 15.later

@mavasani mavasani modified the milestones: 15.later, 15.5 Sep 7, 2017
@jinujoseph jinujoseph modified the milestones: 15.6, Unknown Nov 2, 2017
@jinujoseph jinujoseph modified the milestones: Unknown, 15.8 Jun 23, 2018
@jinujoseph
Copy link
Contributor

group it to single issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Analyzers Bug Concept-API This issue involves adding, removing, clarification, or modification of an API. Feature - IOperation IOperation _Product-level triaged
Projects
None yet
Development

No branches or pull requests

5 participants