IIncrementExpression exposes both UnaryOperatorKind and BinaryOperatorKind

[mavasani]

IIncrementExpression exposes UnaryOperatorKind but it's base type ICompoundAssignmentExpression expose BinaryOperatorKind.

Tagging @dotnet/analyzer-ioperation and @heejaechang who is working on unary operator tests.

[jinujoseph]

Design Team Notes

We need to simplify the hierarchy, The intend here is we are not going to have the complex inheritance hierarchy where in the same hierarchy there is lot of base. We should try to make it more flat and narrow. IExpression might have Iincrementexpression, IcompondAssignment , IAssignementExpression and those themselves can implement side hierarchy, which can be call as infos which are not Ioperation Kind , Say IAssignmentInfos and some one can uniformally operate on this things.

Also look at #8834,#8835 while fixing this as well.

[mavasani]

@heejaechang Did we check in unit tests for unary operations?

[jinujoseph]

Nope, it's still pending #18136

[heejaechang]

@mavasani ha ha not yet!

[jinujoseph]

@heejaechang , you can close this issue onces the test is checked in.