Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IOperation: UnaryOperationKind feels unnecessary complicated #8834

Closed
AlekseyTs opened this issue Feb 17, 2016 · 2 comments
Closed

IOperation: UnaryOperationKind feels unnecessary complicated #8834

AlekseyTs opened this issue Feb 17, 2016 · 2 comments
Assignees
@mavasani
Labels
Area-Analyzers Bug Concept-API This issue involves adding, removing, clarification, or modification of an API. Feature - IOperation IOperation Urgency-Soon
Milestone
15.5

Comments

@AlekseyTs
Copy link
Contributor

Why are we going through the trouble of combining operator kind with type of arguments? Does this really make things easier for consumers? It feels that operator kind is sufficient enough and the type of the operand can be accessed from the Operand.
@AlekseyTs AlekseyTs added Bug Area-Analyzers Concept-API This issue involves adding, removing, clarification, or modification of an API. labels Feb 17, 2016
@AlekseyTs AlekseyTs added this to the 1.2 milestone Feb 17, 2016
@genlu genlu added the Feature - IOperation IOperation label Feb 18, 2016
@msJohnHamby
Copy link
Contributor

Parallel discussion is in #8835

@srivatsn srivatsn modified the milestones: 1.2, 1.3 Feb 26, 2016
@ManishJayaswal ManishJayaswal modified the milestones: 1.3, 2.0 (RC) May 31, 2016
@jinujoseph jinujoseph mentioned this issue Apr 18, 2017
Closed
@jinujoseph jinujoseph added this to the 15.5 milestone Jun 27, 2017
@jinujoseph jinujoseph mentioned this issue Jul 13, 2017
Closed
3 tasks
@mavasani mavasani assigned mavasani and unassigned heejaechang Aug 9, 2017
mavasani added a commit to mavasani/roslyn that referenced this issue Aug 9, 2017
@mavasani
IBinaryOperatorExpression, IUnaryOperatorExpression and IIncrementExp…
8526302 
…ression API changes

This implements a bunch of changes to the IOperation representation for binary operator, unary operator and increment expressions.

1. dotnet#8834: Simplify `UnaryOperatorKind` to only contain the operator kind values instead of a matrix of operator and operand kinds.
2. dotnet#8835: Simplify `BinaryOperatorKind` in similar manner as above.
3. dotnet#8825: Add `IUnaryOperatorExpression.IsChecked` flag. Cyrus has already added the `IUnaryOperatorExpression.IsLifted` flag.
4. dotnet#8846: Add `IBinaryOperatorExpression.IsChecked` and `IBinaryOperatorExpression.IsCompareText` flags Cyrus has already added the `IBinaryOperatorExpression.IsLifted` flag.
5. dotnet#21283: Add `IIncrementExpression.IsDecrement` and `IIncrementExpression.IsPostfix` flags and remove PostFix/Prefix Increment/Decrement from `UnaryOperatorKind` enum.

This change also fixes dotnet#8848 and dotnet#8843 as the matrix operation kind enums no longer exist.
@mavasani mavasani mentioned this issue Aug 9, 2017
Merged
@mavasani
Copy link
Contributor

Fixed with #21407

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mavasani mavasani

Labels
Area-Analyzers Bug Concept-API This issue involves adding, removing, clarification, or modification of an API. Feature - IOperation IOperation Urgency-Soon
Projects
None yet
Milestone
15.5
Development

No branches or pull requests
8 participants
@srivatsn @genlu @heejaechang @ManishJayaswal @AlekseyTs @mavasani @msJohnHamby @jinujoseph