IArrayCreationExpression.Dimensions for explicit versus implicit case

[mavasani]

An IArrayCreationExpression might have explicitly specified or implicitly generated dimensions. Currently, we expose all the Dimension IOperations, regardless of whether they are explicit in source or implicitly computed by the compiler: http://source.roslyn.io/#Microsoft.CodeAnalysis/Compilation/IExpression.cs,1227

Open questions:

1. Should the Dimensions exposed on IArrayCreationExpression filter out implicitly computed dimension?
2. If yes, should we have a separate helper (extension) method on IArrayCreation to get implicitly computed dimensions and rename the current Dimensions property to something like ExplicitDimensions?
3. If no, what is the expectation from an analyzer analyzing and reporting diagnostics on numerical literals? We can't expect all such analyzers to check for generated IOperations...

[jinujoseph]

Design Team Decision

It was decided that for Ioperation API in general, when we will have compiler generated or Implicitly computed by compiler code exposed for all Ioperation nodes and a IsImplicit flag will be set to true to indicate the same.

It was also decided that we will not have an API on the Analysis context to register/configure to filter out the compiler generated code. For example analyzer author won't be able to say i am only interested in analyzing the invocations but don't call back on compiler generated expressions.
We can add that in future based on ask and scenarios.

[bkoelman]

Is this decision about IArrayCreationExpression or IOperation in general? I'm still hoping that WasCompilerGenerated will be publicly exposed, but this may be unrelated.

[jinujoseph]

@bkoelman i have updated the comments to clarify.

[bkoelman]

Thanks

[tmat]

Resolved by #21363