IOperation - IOperation API for BoundMethodGroup and BoundPropertyGroup

[CyrusNajmabadi]

Would be valuable for things like INameOfExpression: #19954

Probably also want this for IBadInvocationExpression where the member group can specify the members that the compiler considered.

[CyrusNajmabadi]

Tagging @dotnet/analyzer-ioperation

[jinujoseph]

@CyrusNajmabadi needed for V1 ?

[jinujoseph]

No. We don't need this for V1. However, whoever does Nameof needs to make sure it exposes the list of members that were bound.

[mavasani]

I think it is weird to expose members within a nameof expression - in fact the BoundNameOfOperator node doesn't even include any BoundMethodGroup or BoundPropertyGroup: http://source.roslyn.io/#Microsoft.CodeAnalysis.CSharp/Generated/BoundNodes.xml.Generated.cs,985506451dde049a.

Instead a better alternative is to just expose the nameof argument as an IOperation, and in future expose these groups. Until then, the recommendation across our entire API surface should be to revert to semantic model to get bound method and property groups.

[CyrusNajmabadi]

I think it is weird to expose members within a nameof expression

I don't think it's weird. It's what the entity inside the nameof ends up meaning semantically.

Until then, the recommendation across our entire API surface should be to revert to semantic model to get bound method and property groups.

This is undesirable because now you have to go back to syntax, and handle the syntax for each language separately just to ask a question that can be answered at our common ioperation layer.

That said, if this is hard to provide (due to how the bound nodes are structured), then i think it's ok if we punt on having the INameOfOperation actually expose any additional information. We can design and add such a thing later.

[jinujoseph]

Design Team Decision

Lets leave this as is for V1 release.

[mavasani]

@heejaechang Wants to discuss this in the design meeting.

[mavasani]

We need to fix this for 15.5 so that children of bound method and property group are not cut - should be a trivial bug fix.

[333fred]

Closing as a duplicate of a community-driven issue, #76620.

[CyrusNajmabadi]

WFM.