Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor & Decide on interface versus abstract type #18246

Closed
mavasani opened this issue Mar 28, 2017 · 2 comments
Closed

Refactor & Decide on interface versus abstract type #18246

mavasani opened this issue Mar 28, 2017 · 2 comments
Assignees
@heejaechang
Labels
0 - Backlog Area-Analyzers Feature - IOperation IOperation Feature Request

Comments

@mavasani
Copy link
Contributor

Tagging @heejaechang, who would like to discuss this in the API design meeting.
@mavasani mavasani added Area-Analyzers Concept-API This issue involves adding, removing, clarification, or modification of an API. Feature - IOperation IOperation labels Mar 28, 2017
This was referenced Mar 28, 2017
Closed
Merged
@jinujoseph
Copy link
Contributor

Design Meeting Notes

This depends on how we implement Laziness, if laziness is implemented by lamda which can be left completely pure datatype without having any strong reference to C#/VB or no strong reference to roslyn then we can take the abstract type route.
But if we do laziness needs location which needs a strong reference to language specific operation type, then other languages will need interfaces to be available to them.

We need to revisit this after we investigate lazy scenarios and their implementation.

@jinujoseph jinujoseph added this to the 15.3 milestone Apr 4, 2017
@jinujoseph jinujoseph removed the Concept-API This issue involves adding, removing, clarification, or modification of an API. label Apr 18, 2017
@jinujoseph jinujoseph changed the title API design: IOperation as an interface versus abstract type Refactor & Decide on interface versus abstract type Apr 20, 2017
@heejaechang heejaechang mentioned this issue Apr 20, 2017
Merged
@jinujoseph
Copy link
Contributor

VB factory checked in via #19073

@jinujoseph jinujoseph modified the milestones: 15.6, 15.3 May 8, 2017
@jinujoseph jinujoseph removed this from the 15.5 milestone Jul 3, 2017
@tmat tmat closed this as completed Sep 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heejaechang heejaechang

Labels
0 - Backlog Area-Analyzers Feature - IOperation IOperation Feature Request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tmat @heejaechang @mavasani @jinujoseph