Added VB Operation Factory #19073
Added VB Operation Factory #19073
Conversation
heejaechang
added
the
PR For Personal Review Only
|
@AdamSpeight2008 style can be done later. |
heejaechang
removed
the
PR For Personal Review Only
|
@dotnet/roslyn-analysis can you take a look? @dotnet/analyzer-ioperation |
| End Function | ||
| Private Shared Function CreateBoundCallOperation(boundCall As BoundCall) As IInvocationExpression | ||
| Dim targetMethod As IMethodSymbol = boundCall.Method | ||
| Dim instance As Lazy(Of IOperation) = New Lazy(Of IOperation)(Function() If(boundCall.Method.IsShared, Nothing, DirectCast(Create(boundCall.ReceiverOpt), IOperation))) |
There was a problem hiding this comment.
Dim instance As New Lazy(Of IOperation)(Function() If(boundCall.Method.IsShared, Nothing, DirectCast(Create(boundCall.ReceiverOpt), IOperation)))There was a problem hiding this comment.
unnecessary cast is there since code is auto-generated.
There was a problem hiding this comment.
That's it is producing sub-optimal stylistic code.
There was a problem hiding this comment.
I will do style only clean up PR next time.
|
|
||
| Private Shared Function GetChildOfBadExpression(parent As BoundNode, index As Integer) As IOperation | ||
| Dim badParent As BoundBadExpression = TryCast(parent, BoundBadExpression) | ||
| If badParent IsNot Nothing AndAlso badParent.ChildBoundNodes.Length > index Then |
There was a problem hiding this comment.
If badParent ?.ChildBoundNodes.Length > index Then| For Each memberAssignment In objectInitializerExpression.Initializers | ||
| Dim assignment = TryCast(memberAssignment, BoundAssignmentOperator) | ||
| Dim left = assignment?.Left | ||
| If left IsNot Nothing Then |
There was a problem hiding this comment.
If left Is Nothing The Continue For
There was a problem hiding this comment.
If left Is Nothing The Continue For
We prefer block-if to a line-if
| Return arrayType.ElementType | ||
| End If | ||
|
|
||
| Return Nothing |
There was a problem hiding this comment.
Return arrayType?.ElementType| Return clause.OperandOpt | ||
| End If | ||
|
|
||
| If clause.ConditionOpt IsNot Nothing AndAlso clause.ConditionOpt.Kind = BoundKind.BinaryOperator Then |
There was a problem hiding this comment.
If clause.ConditionOpt?.Kind = BoundKind.BinaryOperator Then
|
|
||
| Dim stepValue As BoundExpression = boundFor.StepValue | ||
| If stepValue Is Nothing Then | ||
| stepValue = New BoundLiteral(Nothing, Semantics.Expression.SynthesizeNumeric(controlType, 1), controlType) |
There was a problem hiding this comment.
stepValue = If( stepValue, New BoundLiteral(Nothing, Semantics.Expression.SynthesizeNumeric(controlType, 1), controlType))
|
@AlekseyTs @cston @jcouv can you take a look? |
|
@dotnet/roslyn-compiler , @AnthonyDGreen |
|
@dotnet/roslyn-compiler can I get one more compiler dev sign off? |
| @@ -172,7 +172,7 @@ Namespace Microsoft.CodeAnalysis.Semantics | |||
| Dim kind = GetAssignmentKind(boundAssignmentOperator) | |||
| If kind = OperationKind.CompoundAssignmentExpression Then | |||
| Dim binaryOperationKind As BinaryOperationKind = DirectCast(Create(boundAssignmentOperator.Right), IBinaryOperatorExpression).BinaryOperationKind | |||
| Dim target As Lazy(Of IOperation) = New Lazy(Of IOperation)(Function() DirectCast(Create(boundAssignmentOperator.Left), IOperation)) | |||
| Dim target As Lazy(Of IOperation) = New Lazy(Of IOperation)(Function() Create(boundAssignmentOperator.Left)) | |||
There was a problem hiding this comment.
Most of the code that as the form
Dim target As Lazy(Of IOperation) = New Lazy(Of IOperation)(Function() Create(boundAssignmentOperator.Left))
can be changed to,
Dim target As New Lazy(Of IOperation)(Function() Create(boundAssignmentOperator.Left))
without affecting the code.
There was a problem hiding this comment.
right now, I will just leave the code as it is.
|
LGTM |
added VB Operation Factory.