Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider creating VerifyModifiers(MethodSymbol, DeclarationModifiers) test helper to use in DefaultInterfaceImplementationTests.cs #19116

Open
AlekseyTs opened this issue Apr 28, 2017 · 1 comment
Open

Consider creating VerifyModifiers(MethodSymbol, DeclarationModifiers) test helper to use in DefaultInterfaceImplementationTests.cs #19116

AlekseyTs opened this issue Apr 28, 2017 · 1 comment
Assignees
@AlekseyTs
Labels
Area-Compilers Feature - Default Interface Impl Default Interface Implementation Language-C# Test Test failures in roslyn-CI
Milestone
Backlog

Comments

@AlekseyTs
Copy link
Contributor

Here is a link to PR comment that prompted creation of this issue #19080 (review).

I personally don't believe it is worth spending time on that refactoring (introducing the helper and changing existing tests to use it) because it is unlikely that significant number of tests added in the future will need that helper.
@AlekseyTs AlekseyTs added Area-Compilers Language-C# Feature - Default Interface Impl Default Interface Implementation Test Test failures in roslyn-CI labels Apr 28, 2017
@AlekseyTs AlekseyTs mentioned this issue Apr 28, 2017
Merged
@gafter gafter added this to the 16.0 milestone Feb 9, 2018
@gafter
Copy link
Member

gafter commented Feb 9, 2018

@AlekseyTs Please work with @jcouv and @cston to decide if this needs to be done.

@jinujoseph jinujoseph modified the milestones: 16.0, 16.3 Jun 9, 2019
@jcouv jcouv modified the milestones: 16.3, Compiler.Next Jul 16, 2019
@jaredpar jaredpar modified the milestones: Compiler.Next, Backlog Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlekseyTs AlekseyTs

Labels
Area-Compilers Feature - Default Interface Impl Default Interface Implementation Language-C# Test Test failures in roslyn-CI
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
5 participants
@jaredpar @gafter @AlekseyTs @jinujoseph @jcouv