Support public, internal, private, static, virtual, sealed, abstract, and extern modifiers with interface events. #19080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and extern modifiers with interface events.
cston
reviewed
Apr 28, 2017
| Assert.False(p01.IsSealed); | ||
| Assert.False(p01.IsStatic); | ||
| Assert.False(p01.IsExtern); | ||
| Assert.False(p01.IsOverride); |
There was a problem hiding this comment.
Please consider adding a VerifyModifiers(MethodSymbol, DeclarationModifiers) helper.
There was a problem hiding this comment.
Opened an issue #19116.
jcouv
approved these changes
Apr 28, 2017
AlekseyTs
added
Area-Compilers
Language-C#
Feature - Default Interface Impl
|
@dotnet/roslyn-compiler Please review, need a second sign-off. |
cston
reviewed
May 1, 2017
| @@ -80,6 +80,11 @@ internal SourceFieldLikeEventSymbol(SourceMemberContainerTypeSymbol containingTy | |||
| // Don't initialize this.type - we'll just use the type of the field (which is lazy and handles var) | |||
| } | |||
|
|
|||
| if (inInterfaceType && !this.IsAbstract && !this.IsExtern) | |||
| { | |||
| diagnostics.Add(ErrorCode.ERR_EventNeedsBothAccessors, this.Locations[0], this); | |||
There was a problem hiding this comment.
Why is this an error?
Because non-abstract, non-extern events should declare both accessors with implementation.
cston
reviewed
May 1, 2017
| ValidateAccessor(p1.AddMethod); | ||
| ValidateAccessor(p1.RemoveMethod); | ||
|
|
||
| void ValidateAccessor(MethodSymbol acessor) |
There was a problem hiding this comment.
Typo: accessor
Thanks, will fix throughout the file in the next PR.
cston
reviewed
May 1, 2017
| System.Console.WriteLine(""get_P1""); | ||
| } | ||
| remove | ||
|
|
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dotnet/roslyn-compiler Please review.