Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'Live analyzers' check crashses. #19629

Closed
CyrusNajmabadi opened this issue May 18, 2017 · 5 comments
Closed

'Live analyzers' check crashses. #19629

CyrusNajmabadi opened this issue May 18, 2017 · 5 comments
Assignees
@heejaechang
Labels
Area-Analyzers Urgency-Now
Milestone
15.3

Comments

@CyrusNajmabadi
Copy link
Member 

Application: devenv.exe
Framework Version: v4.0.30319
Description: The process was terminated due to an unhandled exception.
Exception Info: System.InvalidCastException
   at Microsoft.CodeAnalysis.Options.OptionSet.GetOption[[System.Int64, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]](Microsoft.CodeAnalysis.Options.Option`1<Int64>)
   at Microsoft.VisualStudio.LanguageServices.Implementation.Experimentation.AnalyzerVsixSuggestedActionCallback.IsCandidate()
   at Microsoft.VisualStudio.LanguageServices.Implementation.Experimentation.AnalyzerVsixSuggestedActionCallback.OnSuggestedActionExecuted(Microsoft.CodeAnalysis.Editor.Implementation.Suggestions.SuggestedAction)
@CyrusNajmabadi
Copy link
Member Author

Tagging @333fred @jinujoseph

@jinujoseph jinujoseph added this to the 15.3 milestone May 18, 2017
@mavasani
Copy link
Contributor

I think this is blocking the VSI queue, marking urgency now.

@CyrusNajmabadi
Copy link
Member Author

Fred is out. I will disable this codepath for now.

@jinujoseph
Copy link
Contributor

@heejaechang is looking in the meanwhile

@CyrusNajmabadi CyrusNajmabadi mentioned this issue May 18, 2017
Merged
@CyrusNajmabadi
Copy link
Member Author

Oh. I have a fix available now to unblock people. It disables the feature currently. I'd like us to send that in while Heejae can work on a proper fix.

Heejae, we likely just need to make the options persistence layer 'long' or 'DateTime' aware.

@jasonmalinowski jasonmalinowski mentioned this issue May 18, 2017
Merged
jasonmalinowski added a commit to jasonmalinowski/roslyn that referenced this issue May 19, 2017
@jasonmalinowski
Support serializing longs to/from the local registry
f4ea5d0 
Fixes dotnet#19629.
jasonmalinowski added a commit to jasonmalinowski/roslyn that referenced this issue May 22, 2017
@jasonmalinowski
Support serializing longs to/from the local registry
6dabca8 
Fixes dotnet#19629.
AdamSpeight2008 pushed a commit to AdamSpeight2008/roslyn-AdamSpeight2008 that referenced this issue Jun 4, 2017
@jasonmalinowski @AdamSpeight2008
Support serializing longs to/from the local registry
72355d6 
Fixes dotnet#19629.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heejaechang heejaechang

Labels
Area-Analyzers Urgency-Now
Projects
None yet
Milestone
15.3
Development

No branches or pull requests
4 participants
@heejaechang @CyrusNajmabadi @mavasani @jinujoseph