Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BoundRangeVariable should not exist in the C# operation tree #23079

Closed
mavasani opened this issue Nov 8, 2017 · 3 comments
Closed

BoundRangeVariable should not exist in the C# operation tree #23079

mavasani opened this issue Nov 8, 2017 · 3 comments
Assignees
@mavasani
Labels
Area-Analyzers Bug Feature - IOperation IOperation
Milestone
15.6

Comments

@mavasani
Copy link
Contributor

mavasani commented Nov 8, 2017

As noted in #21356 (comment), we are still exposing bound range variables in C# operation tree, which should have been rewritten to bound parameter references to lambda parameter.
@mavasani
Copy link
Contributor Author

mavasani commented Nov 8, 2017

@AlekseyTs @jinujoseph Do we want to target this for 15.5?

@mavasani mavasani self-assigned this Nov 8, 2017
@mavasani mavasani mentioned this issue Nov 8, 2017
Closed
@AlekseyTs
Copy link
Contributor

Do we want to target this for 15.5?

I think it would be good to fix for 15.5.

mavasani added a commit to mavasani/roslyn that referenced this issue Nov 8, 2017
@mavasani
Do not expose operation nodes for BoundRangeVariables in C# query exp…
64fe5e5 
…ression

These nodes contain the bound parameter reference to the underlying lambda parameter, which is now exposed.
Fixes dotnet#23079
This was referenced Nov 8, 2017
Closed
Merged
@jinujoseph jinujoseph modified the milestones: 15.5, 15.6 Nov 9, 2017
@jinujoseph jinujoseph added the 4 - In Review A fix for the issue is submitted for review. label Nov 13, 2017
@mavasani
Copy link
Contributor Author

Fixed with #23080

@gafter gafter removed 4 - In Review A fix for the issue is submitted for review. labels Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mavasani mavasani

Labels
Area-Analyzers Bug Feature - IOperation IOperation
Projects
None yet
Milestone
15.6
Development

No branches or pull requests
4 participants
@gafter @AlekseyTs @mavasani @jinujoseph