CoreCompile does not consider imported rulesets as inputs

[sharwell]

The CoreCompile target considers the main ruleset file for a compilation as an input, so changes to the file will cause the build output to change:

roslyn/src/Compilers/Core/MSBuildTask/Microsoft.CSharp.Core.targets

Line 29 in aa683ac

$(ResolvedCodeAnalysisRuleSet);

However, ruleset files are allowed to import other ruleset files:

roslyn/build/Rulesets/NonShippingProject_BuildRules.ruleset

Line 3 in 8775371

<Include Path=".\Roslyn_BuildRules.ruleset" Action="Default" />

These imported files are not tracked by the ResolvedCodeAnalysisRuleSet property, and changes to them do not trigger a build.

[jcouv]

@agocke Feels like we should keep this issue in 16.3. May want to load-balance it though.

[Youssef1313]

@mavasani @sharwell Do we care about ruleset issues anymore?

[mavasani]

@mavasani @sharwell Do we care about ruleset issues anymore?

I don’t think we want to do anything here unless there is strong customer requirement for it