Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nullable: re-enable skipped EnC tests now that NonNullTypesAttribute isn't injected #29662

Closed
jcouv opened this issue Sep 4, 2018 · 1 comment
Closed

Nullable: re-enable skipped EnC tests now that NonNullTypesAttribute isn't injected #29662

jcouv opened this issue Sep 4, 2018 · 1 comment
Assignees
@jcouv
Labels
Area-Compilers Feature - Nullable Reference Types Nullable Reference Types Test Test failures in roslyn-CI
Milestone
16.0

Comments

@jcouv
Copy link
Member

jcouv commented Sep 4, 2018

These two tests run into an assertion:

  • AddedAsyncStateMachineAttribute
  • AddedIteratorStateMachineAttribute

Both tests were trying to add an attribute in the System.Runtime.CompilerServices namespace.
@jcouv jcouv added this to the 16.0 milestone Sep 4, 2018
@jaredpar jaredpar added the Bug label Sep 4, 2018
@jcouv
Copy link
Member Author

jcouv commented Nov 2, 2018

It should be possible to re-enable those two tests now, since the attribute is no longer injected.

@jcouv jcouv self-assigned this Nov 10, 2018
@jcouv jcouv added Test Test failures in roslyn-CI and removed Bug labels Nov 12, 2018
@jcouv jcouv changed the title Fix EnC with injected NonNullTypes attribute Nullable: re-enable skipped EnC tests now that NonNullTypesAttribute isn't injected Nov 12, 2018
@jcouv jcouv mentioned this issue Nov 19, 2018
Merged
AlekseyTs added a commit to AlekseyTs/roslyn that referenced this issue Nov 19, 2018
@AlekseyTs
PR feedback.
6160520 
Closes dotnet#29683
Closes dotnet#29662
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcouv jcouv

Labels
Area-Compilers Feature - Nullable Reference Types Nullable Reference Types Test Test failures in roslyn-CI
Projects
None yet
Milestone
16.0
Development

No branches or pull requests
2 participants
@jaredpar @jcouv