Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need mechanism for injecting annotations #29821

Closed
jcouv opened this issue Sep 13, 2018 · 1 comment
Closed

Need mechanism for injecting annotations #29821

jcouv opened this issue Sep 13, 2018 · 1 comment
Assignees
@gafter
Labels
Area-Compilers Area-Language Design Bug New Language Feature - Nullable Reference Types Nullable Reference Types Resolution-By Design The behavior reported in the issue matches the current design
Milestone
16.2

Comments

@jcouv
Copy link
Member

jcouv commented Sep 13, 2018 •
edited by AlekseyTs
Loading

This is a follow-up workitem to replace a number of PROTOTYPE markers.

Design issues:

  • Right now extra annotations always win (even if we're loading a modern assembly). Is this what we want?

FYI @AlekseyTs
@jcouv jcouv added this to the 16.0 milestone Sep 13, 2018
@jaredpar jaredpar added the Bug label Sep 13, 2018
@cston cston mentioned this issue Nov 10, 2018
Closed
@jcouv jcouv modified the milestones: 16.0, 16.0.P2 Nov 10, 2018
@jcouv jcouv modified the milestones: 16.0.P2, 16.0 Jan 1, 2019
@gafter gafter modified the milestones: 16.0, 16.1 Feb 26, 2019
@gafter gafter self-assigned this Apr 10, 2019
@gafter gafter removed their assignment Apr 10, 2019
gafter added a commit to gafter/roslyn that referenced this issue Apr 10, 2019
@gafter
Remove the temporary mechanism for "external" annotations.
01e3e72 
Relates to dotnet#29821
@gafter gafter mentioned this issue Apr 10, 2019
Merged
@gafter gafter self-assigned this Apr 10, 2019
@jcouv jcouv modified the milestones: 16.1, 16.2 Apr 23, 2019
@jcouv
Copy link
Member Author

jcouv commented May 4, 2019

Closing this issue, as LDM decided against a mechanism for external annotations.

@jcouv jcouv closed this as completed May 4, 2019
@jcouv jcouv added the Resolution-By Design The behavior reported in the issue matches the current design label May 4, 2019
gafter pushed a commit that referenced this issue Jul 15, 2019
Remove the temporary mechanism for "external" nullable annotations. (#…
bb08465 
…34916)

Relates to #29821
Fixes #34409
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gafter gafter

Labels
Area-Compilers Area-Language Design Bug New Language Feature - Nullable Reference Types Nullable Reference Types Resolution-By Design The behavior reported in the issue matches the current design
Projects
None yet
Milestone
16.2
Development

No branches or pull requests
3 participants
@jaredpar @gafter @jcouv