Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SymbolDisplay should respect SymbolDisplayCompilerInternalOptions.IncludeNonNullableTypeModifier for class constraint #29838

Closed
AlekseyTs opened this issue Sep 13, 2018 · 0 comments
Closed

SymbolDisplay should respect SymbolDisplayCompilerInternalOptions.IncludeNonNullableTypeModifier for class constraint #29838

AlekseyTs opened this issue Sep 13, 2018 · 0 comments
Labels
Area-Compilers Bug Feature - Nullable Reference Types Nullable Reference Types Language-C#
Milestone
16.0

Comments

@AlekseyTs
Copy link
Contributor

When SymbolDisplayCompilerInternalOptions.IncludeNonNullableTypeModifier is set and "TypeParameterSymbol.ReferenceTypeConstraintIsNullable == true", the class constraint should have an ExclamationToken. I.e. the output should look like class!.

Relevant code is in private void AddTypeParameterConstraints(ImmutableArray<ITypeSymbol> typeArguments).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Compilers Bug Feature - Nullable Reference Types Nullable Reference Types Language-C#
Projects
None yet
Milestone
16.0
Development

No branches or pull requests
3 participants
@jaredpar @AlekseyTs @jcouv