Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IOperation concrete nodes (internal) should not have ctor args for type and constant value when inapplicable #31150

Open
gafter opened this issue Nov 13, 2018 · 0 comments
Open

IOperation concrete nodes (internal) should not have ctor args for type and constant value when inapplicable #31150

gafter opened this issue Nov 13, 2018 · 0 comments
Labels
Area-Compilers Concept-Design Debt Engineering Debt, Design Debt, or poor product code quality Feature - IOperation IOperation
Milestone
Backlog

Comments

@gafter
Copy link
Member

gafter commented Nov 13, 2018

The concrete types that implement IOperation nodes should not have constructor arguments for type and constantValue when those are inapplicable to the kind of node.
gafter added a commit to gafter/roslyn that referenced this issue Nov 13, 2018
@gafter
Prevent type and constant value on a constant pattern
c9da431 
See also dotnet#31150
gafter pushed a commit that referenced this issue Nov 28, 2018
Restore flow graph produced for existing switch statements (#31129)
b90b792 
* Restore flow graph produced for existing switch statements
Fixes #28634
* Prevent type and constant value on a constant pattern
See also #31150
* Skip `AddResourceToModule` on Linux
Issue reported as #31279
@gafter gafter added this to the Backlog milestone Aug 2, 2019
@gafter gafter added the Concept-Design Debt Engineering Debt, Design Debt, or poor product code quality label Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Compilers Concept-Design Debt Engineering Debt, Design Debt, or poor product code quality Feature - IOperation IOperation
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
1 participant
@gafter