Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stepping through switch expression is wrong #32370

Closed
jcouv opened this issue Jan 11, 2019 · 2 comments
Closed

Stepping through switch expression is wrong #32370

jcouv opened this issue Jan 11, 2019 · 2 comments
Assignees
@gafter
Labels
4 - In Review A fix for the issue is submitted for review. Area-Compilers Feature - Pattern Matching Pattern Matching
Milestone
16.1

Comments

@jcouv
Copy link
Member

jcouv commented Jan 11, 2019 •
edited
Loading

The whole statement with the switch expression never gets highlighted as I step forward.

switch-stepping

When fixing this, please also verify that LUT (live unittesting) instrumentation works.
@jcouv jcouv added this to the 16.0 milestone Jan 11, 2019
@gafter
Copy link
Member

gafter commented Jan 24, 2019

The switch expression should have no impact on LUT. I will add switch expressions to some existing LUT tests to confirm that there is no change in expected LUT results.

gafter added a commit to gafter/roslyn that referenced this issue Jan 24, 2019
@gafter
Remove spurious hidden sequence points for switch expression
93fcef7 
Fixes dotnet#32370

Fix parsing error recovery for incomplete switch expression
Fixes dotnet#32749
@gafter gafter mentioned this issue Jan 24, 2019
Merged
@gafter gafter modified the milestones: 16.0, 16.0.P3, 16.0.P4 Jan 25, 2019
@gafter gafter added the 4 - In Review A fix for the issue is submitted for review. label Jan 31, 2019
@gafter gafter modified the milestones: 16.0.P4, 16.1 Jan 31, 2019
@gafter
Copy link
Member

gafter commented Feb 15, 2019

Fixed in #32755 for dev16.0

@gafter gafter closed this as completed Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gafter gafter

Labels
4 - In Review A fix for the issue is submitted for review. Area-Compilers Feature - Pattern Matching Pattern Matching
Projects
None yet
Milestone
16.1
Development

No branches or pull requests
2 participants
@gafter @jcouv