Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch expression in nullable walker #32414

Closed
gafter opened this issue Jan 12, 2019 · 0 comments
Closed

switch expression in nullable walker #32414

gafter opened this issue Jan 12, 2019 · 0 comments
Assignees
@gafter
Labels
Area-Compilers Feature - Nullable Reference Types Nullable Reference Types Feature - Pattern Matching Pattern Matching Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented
Milestone
16.1.P2

Comments

@gafter
Copy link
Member

gafter commented Jan 12, 2019

It has been reported to me that the nullable walker does not currently handle the switch expression.
@gafter gafter added this to the 16.0.P3 milestone Jan 12, 2019
@gafter gafter self-assigned this Jan 12, 2019
@gafter gafter modified the milestones: 16.0.P3, 16.0.P4 Jan 25, 2019
@jaredpar jaredpar modified the milestones: 16.0.P4, 16.1.P1 Jan 27, 2019
@jcouv jcouv mentioned this issue Mar 14, 2019
Merged
gafter added a commit to gafter/roslyn that referenced this issue Mar 19, 2019
@gafter
Mark tests with issue
5890c02 
Fixes dotnet#32414
@gafter gafter mentioned this issue Mar 19, 2019
Closed
gafter pushed a commit to gafter/roslyn that referenced this issue Mar 19, 2019
@gafter
Implement pattern-matching in the nullable walker
7a0e3df 
Fixes dotnet#29909
Fixes dotnet#31881
Fixes dotnet#30952
Fixes dotnet#33499
Fixes dotnet#30597
Fixes dotnet#32414
Fixes dotnet#23944
gafter pushed a commit to gafter/roslyn that referenced this issue Mar 19, 2019
@gafter
Implement pattern-matching in the nullable walker
ebe1e7f 
Fixes dotnet#29909
Fixes dotnet#31881
Fixes dotnet#30952
Fixes dotnet#33499
Fixes dotnet#30597
Fixes dotnet#32414
Fixes dotnet#23944
@gafter gafter mentioned this issue Mar 19, 2019
Merged
jaredpar pushed a commit that referenced this issue Mar 30, 2019
@jaredpar
Implement pattern-matching in the nullable walker (#34273)
583505c 
* Implement pattern-matching in the nullable walker

Fixes #29909
Fixes #31881
Fixes #30952
Fixes #33499
Fixes #30597
Fixes #32414
Fixes #23944

* Remove infinite recursion by using an empty struct cache.

* Changes per code review comments.

* Remove debugging code accidentally left behind.

* Analysis of patterns-matching in the nullable walker requires valid (>0) slots.

* Skip a flaky test

* Patch after merge.

* Make ctor private to force use of factory methods

* Correct a typo.

* Fixup after merge.
@sharwell sharwell added the Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented label Mar 30, 2019
@sharwell sharwell modified the milestones: 16.1.P1, 16.1.P2 Mar 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gafter gafter

Labels
Area-Compilers Feature - Nullable Reference Types Nullable Reference Types Feature - Pattern Matching Pattern Matching Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented
Projects
None yet
Milestone
16.1.P2
Development

No branches or pull requests
3 participants
@jaredpar @sharwell @gafter