Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure NullableWalker.InheritNullableStateOfMember is not copying state for invalid members #33428

Closed
cston opened this issue Feb 15, 2019 · 0 comments · Fixed by #39301
Closed

Ensure NullableWalker.InheritNullableStateOfMember is not copying state for invalid members #33428

cston opened this issue Feb 15, 2019 · 0 comments · Fixed by #39301
Assignees
@gafter
Labels
4 - In Review A fix for the issue is submitted for review. Area-Compilers New Language Feature - Nullable Reference Types Nullable Reference Types
Milestone
16.6

Comments

@cston
Copy link
Member

cston commented Feb 15, 2019

NullableWalker.InheritNullableStateOfMember should assert the member is valid for value and target.
@cston cston self-assigned this Feb 15, 2019
@cston cston mentioned this issue Feb 15, 2019
Merged
@gafter gafter added this to the 16.1 milestone Feb 18, 2019
@jcouv jcouv modified the milestones: 16.1, 16.2 Apr 23, 2019
@jcouv jcouv modified the milestones: 16.2, 16.3 Jun 18, 2019
@cston cston modified the milestones: 16.3, Compiler.Next Jul 9, 2019
@gafter gafter assigned gafter and unassigned cston Oct 15, 2019
@gafter gafter modified the milestones: Compiler.Next, 16.4 Oct 15, 2019
@gafter gafter mentioned this issue Oct 15, 2019
Merged
@agocke agocke modified the milestones: 16.4, 16.5 Nov 1, 2019
gafter pushed a commit to gafter/roslyn that referenced this issue Jan 2, 2020
Partial fix for dotnet#39220
f253208 
Fixes dotnet#39220

Filter out "bad" slots not a member of the container.

Fixes dotnet#33428
@gafter gafter added the 4 - In Review A fix for the issue is submitted for review. label Jan 13, 2020
@jcouv jcouv modified the milestones: 16.5, 16.6 Feb 14, 2020
gafter pushed a commit that referenced this issue Feb 24, 2020
Address issues with nullable flow analysis slot container types and c…
c288341 
…hanging types during inference (#39301)

Fixes #39220
Fixes #39297
Fixes #33428
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gafter gafter

Labels
4 - In Review A fix for the issue is submitted for review. Area-Compilers New Language Feature - Nullable Reference Types Nullable Reference Types
Projects
None yet
Milestone
16.6
4 participants
@agocke @gafter @cston @jcouv