Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Race condition in SolutionExplorer_InProc.WaitForBuildToFinish #33597

Closed
sharwell opened this issue Feb 22, 2019 · 1 comment
Closed

Race condition in SolutionExplorer_InProc.WaitForBuildToFinish #33597

sharwell opened this issue Feb 22, 2019 · 1 comment
Labels
Area-IDE Bug Integration-Test Test failures in roslyn-integration-CI
Milestone
Backlog

Comments

@sharwell
Copy link
Member

Version Used: f32205e

It's possible for SolutionExplorer_InProc.WaitForBuildToFinish to never return due to a race condition in managing the event states. This method and SolutionExplorer_InProc.BuildSolution should be updated to ensure consistently-correct behavior.
@sharwell sharwell added Bug Area-IDE Integration-Test Test failures in roslyn-integration-CI labels Feb 22, 2019
@sharwell sharwell added this to the Backlog milestone Feb 22, 2019
sharwell added a commit to sharwell/roslyn that referenced this issue Feb 22, 2019
@sharwell
Add a hang mitigating timeout to WaitForBuildToFinish
de8e553 
See dotnet#33597
@sharwell sharwell mentioned this issue Feb 22, 2019
Merged
sharwell added a commit to sharwell/roslyn that referenced this issue Feb 24, 2019
@sharwell
Add a hang mitigating timeout to WaitForBuildToFinish
bb21c06 
See dotnet#33597

(cherry picked from commit de8e553)
@CyrusNajmabadi
Copy link
Member

Closing out as speculative. If we have an issue here, we should just fix it.

@CyrusNajmabadi CyrusNajmabadi closed this as not planned Won't fix, can't repro, duplicate, stale Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-IDE Bug Integration-Test Test failures in roslyn-integration-CI
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@sharwell @CyrusNajmabadi