Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete Statement behaves incorrectly in a multi-line verbatim string that is passed to a method #34176

Closed
chborl opened this issue Mar 15, 2019 · 1 comment
Closed

Complete Statement behaves incorrectly in a multi-line verbatim string that is passed to a method #34176

chborl opened this issue Mar 15, 2019 · 1 comment
Assignees
@chborl
Labels
4 - In Review A fix for the issue is submitted for review. Area-IDE Bug
Milestone
16.1.P1

Comments

@chborl
Copy link
Contributor

chborl commented Mar 15, 2019

adding notes from taylor
image

Originally posted by @jinujoseph in #34088 (comment)
@chborl chborl mentioned this issue Mar 15, 2019
Closed
@chborl chborl changed the title Complete Statement behaves incorrectly in an interpolated that is inside another interpolated statement Complete Statement behaves incorrectly in an interpolated string that is inside another interpolated string Mar 15, 2019
chborl added a commit to chborl/roslyn that referenced this issue Mar 15, 2019
@chborl
Fixes dotnet#34176
14a2006
@chborl chborl changed the title Complete Statement behaves incorrectly in an interpolated string that is inside another interpolated string Complete Statement behaves incorrectly in verbatim string that contains a Razor code block Mar 15, 2019
@chborl chborl mentioned this issue Mar 15, 2019
Merged
@jinujoseph jinujoseph added the Bug label Mar 20, 2019
@jinujoseph jinujoseph added this to the 16.1.P1 milestone Mar 20, 2019
@chborl
Copy link
Contributor Author

chborl commented Mar 21, 2019

Note: The minimal code for reproducing this error is a multi-line verbatim string that is passed to a method:

var code = Foo(@"$$
"

@chborl chborl changed the title Complete Statement behaves incorrectly in verbatim string that contains a Razor code block Complete Statement behaves incorrectly in a multi-line verbatim string that is passed to a method Mar 21, 2019
@jinujoseph jinujoseph added the 4 - In Review A fix for the issue is submitted for review. label Mar 25, 2019
chborl added a commit that referenced this issue Mar 26, 2019
@chborl
Don't complete statement when in multi-line verbatim string that is p…
3617933 
…assed to a method (#34177)

* Fixes #34176

* Fix test name

* Update tests - WIP

* Fix conditional

* Improve conditional

* add tests and check for caret before string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chborl chborl

Labels
4 - In Review A fix for the issue is submitted for review. Area-IDE Bug
Projects
None yet
Milestone
16.1.P1
Development

No branches or pull requests
3 participants
@gafter @jinujoseph @chborl