Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Null suppressions that will be fixed by .NET 5 annotations #41539

Closed
jaredpar opened this issue Feb 10, 2020 · 1 comment · Fixed by #66842
Closed

Null suppressions that will be fixed by .NET 5 annotations #41539

jaredpar opened this issue Feb 10, 2020 · 1 comment · Fixed by #66842
Labels
Area-Infrastructure Concept-Continuous Improvement Concept-Null Annotations The issue involves annotating an API for nullable reference types

Comments

@jaredpar
Copy link
Member

This issue is meant to cover the null suppression operator (!) uses in our code base that will be fixed when we move to the .NET 5 TFM. The APIs in the .NET 5 TFM contain the necessary annotations to let us remove these suppressions.

Specific APIs that we're waiting for the annotation change on:

RuntimeHelpers.GetHashCode`
@jaredpar jaredpar added Bug Concept-Null Annotations The issue involves annotating an API for nullable reference types labels Feb 10, 2020
@jaredpar jaredpar mentioned this issue Feb 10, 2020
Merged
jaredpar added a commit to jaredpar/roslyn that referenced this issue Feb 10, 2020
@jaredpar
Use suppressions for .NET 5 API changes
ed3ef5e 
Filed dotnet#41539 to track the .NET 5 annotation changes
@RikkiGibson
Copy link
Contributor

This should probably be closed in the follow up to #66565.

@jjonescz jjonescz mentioned this issue Feb 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Infrastructure Concept-Continuous Improvement Concept-Null Annotations The issue involves annotating an API for nullable reference types
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unnecessary null suppressions in calls to RuntimeHelpers.GetHashCode jjonescz/roslyn
3 participants
@jaredpar @RikkiGibson @jinujoseph