Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to specify whether options of IOptionsProvider should be part of solution snapshot #42308

Closed
tmat opened this issue Mar 10, 2020 · 1 comment

Comments

@tmat
Copy link
Member

tmat commented Mar 10, 2020

Currently we decide based on the assembly the options provider is in:

// We only consider the options defined in the the DefaultAssemblies (Workspaces and Features) as serializable.
// This is due to the fact that other layers above are VS specific and do not execute in OOP.
if (!MefHostServices.IsDefaultAssembly(provider.GetType().Assembly))

http://sourceroslyn.io/#Microsoft.CodeAnalysis.Workspaces/Options/GlobalOptionService.cs,66

It would be better to explicitly declare where the option should be available via an argument to ExportOptionProvider. E.g. ClientOnly = true would mean the option is not serialized to the solution snapshot.

@tmat tmat added the Concept-OOP Related to out-of-proc label Mar 10, 2020
@jinujoseph jinujoseph added this to the 16.6 milestone Mar 15, 2020
@jinujoseph jinujoseph modified the milestones: 16.6, 16.7 Apr 17, 2020
@jinujoseph jinujoseph modified the milestones: 16.7, 16.8 Jun 19, 2020
@jinujoseph jinujoseph modified the milestones: 16.8, 16.9 Sep 10, 2020
@jinujoseph jinujoseph modified the milestones: 16.9, Backlog Jan 17, 2021
@tmat
Copy link
Member Author

tmat commented May 19, 2022

IOptionsProvider are not needed anymore.

@tmat tmat closed this as completed May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants