Options Refactoring - Round 3 #57254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
tmat
force-pushed
the
Options5
branch
2 times, most recently
from
25ae09e to
4a4be51
Compare
tmat
force-pushed
the
Options5
branch
3 times, most recently
from
9cfbf4b to
ef03058
Compare
sandyarmstrong
approved these changes
Nov 1, 2021
JoeRobich
approved these changes
Nov 1, 2021
| @@ -62,12 +62,6 @@ public int NavigateToDecompiledSources | |||
| set { SetBooleanOption(FeatureOnOffOptions.NavigateToDecompiledSources, value); } | |||
| } | |||
|
|
|||
| public int UseEnhancedColors | |||
| public static readonly PerLanguageOption2<bool> EnableInlineDiagnostics = | ||
| new(nameof(InlineDiagnosticsOptions), | ||
| nameof(EnableInlineDiagnostics), | ||
| new("InlineDiagnosticsOptions", |
There was a problem hiding this comment.
Why is not good to use nameof() here? Easier to move options between code files?
There was a problem hiding this comment.
Because renaming the internal type might break the option (change the key that's used to look it up). There is really no relationship that we need to maintain between the type that declares the option and the option key.
jmarolf
approved these changes
Nov 1, 2021
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Nov 2, 2021
* upstream/main: (51 commits) Disable sql when built from source Fix Reduce indirections Reduce indirections Rename files Fix nullability warning Update cloud cache in the same way Ensure only one storage service factory gets created per workspace. Remove processed typename check Simplify Equals method Build CodeAction description into table and only generate Dev17 hash Avoid recomputing expensive persistence location data that does not change. Options Refactoring - Round 3 (dotnet#57254) Merge pull request dotnet#57509 from dotnet/dev/rigibson/fix-publishdata Classify method group assignments as methods (dotnet#57410) Simplify NRT Simplify Remove unnecessary workaround code. Simplify ...
ryzngard
added
UX Review Not Required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More options refactoring applying patterns described in #55728
Introduces attributes
ExportSolutionOptionProviderandExportGlobalOptionProviderthat derive fromExportOptionProviderbut does not use them yet when importing options. Will follow up on that in a separate PR (issue #42308).Follow-up: #57283