Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests fail to wait for code action application (or silent failure) #57327

Closed
sharwell opened this issue Oct 22, 2021 · 7 comments · Fixed by #60051
Closed

Integration tests fail to wait for code action application (or silent failure) #57327

sharwell opened this issue Oct 22, 2021 · 7 comments · Fixed by #60051
Labels
Area-Infrastructure Integration-Test Test failures in roslyn-integration-CI

Comments

@sharwell
Copy link
Member

sharwell commented Oct 22, 2021

https://dev.azure.com/dnceng/public/_build/results?buildId=1432244

Xunit.Sdk.ContainsException: Assert.Contains() Failure
Not found: ClassLibrary3
In value:  String[] ["ClassLibrary1", "ClassLibrary2"]
   at Xunit.Assert.Contains[T](T expected, IEnumerable`1 collection, IEqualityComparer`1 comparer) in C:\projects\xunit\src\xunit.assert\Asserts\CollectionAsserts.cs:line 114

16 04 50-BasicAddMissingReference InvokeSomeFixesInVisualBasicThenVerifyReferences-ContainsException (1)

Build Kind Start Time
1425665 Rolling 2021-17-10
1426510 Rolling 2021-18-10
1428386 Rolling 2021-18-10
1428256 Rolling 2021-18-10
1430603 Rolling 2021-19-10
1430869 Rolling 2021-19-10
1432244 Rolling 2021-20-10
1434178 PR 57029 2021-21-10
1434386 PR 57300 2021-21-10
1434538 PR 55469 2021-21-10
1434564 PR 57305 2021-21-10
1434504 PR 57084 2021-21-10
1434626 PR 57306 2021-21-10
1434813 PR 57254 2021-21-10
1434988 PR 57284 2021-21-10
1435049 PR 57310 2021-21-10
1435242 PR 57312 2021-21-10
1435296 PR 57303 2021-21-10
1435190 PR 57290 2021-21-10
1435421 PR 57228 2021-21-10
1435484 PR 56276 2021-22-10
1436064 PR 57029 2021-22-10
1436110 PR 56197 2021-22-10
1436306 PR 54559 2021-22-10
1436419 PR 45105 2021-22-10
1436477 Rolling 2021-22-10
1436429 Rolling 2021-22-10
1436565 PR 57266 2021-22-10
1436574 Rolling 2021-22-10
1436611 Rolling 2021-22-10
1440184 Rolling 2021-26-10
1440339 PR 56957 2021-26-10
1440379 PR 57380 2021-26-10
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Oct 22, 2021
@sharwell sharwell added the Integration-Test Test failures in roslyn-integration-CI label Oct 22, 2021
@sharwell sharwell changed the title Integration tests fail to wait for code action application Integration tests fail to wait for code action application (or silent failure) Oct 22, 2021
@jasonmalinowski
Copy link
Member

Any chance this is fallout from the async lightbulb issues? @CyrusNajmabadi?

@CyrusNajmabadi
Copy link
Member

@jasonmalinowski discussing this with @AmadeusW now. He's observed this on their end as well. There are times when roslyn returns results, but they don't display. It's one of the reasons we're disabling async-lightbulbs for 17.0.

I hope we can track this down and fix early in the 17.1 timeframe.

@jasonmalinowski
Copy link
Member

@CyrusNajmabadi Alright, good to know there's a chance it's related.

@jinujoseph jinujoseph removed the untriaged Issues and PRs which have not yet been triaged by a lead label Oct 27, 2021
@jinujoseph jinujoseph added this to the 17.1 milestone Oct 27, 2021
@CyrusNajmabadi CyrusNajmabadi modified the milestones: 17.1, 17.2 Dec 15, 2021
@CyrusNajmabadi
Copy link
Member

@sharwell @jasonmalinowski are we still seeing this with the latest bits from platform?

@sharwell
Copy link
Member Author

sharwell commented Dec 15, 2021

@CyrusNajmabadi I never saw clear evidence that this issue was caused by the platform. It seemed more related to Windows Defender triggering file change notifications at unexpected times, and is mitigated in the new integration test library by a79d0e0 (once merged).

@CyrusNajmabadi
Copy link
Member

Ok. I'm unassigning me then :)

@CyrusNajmabadi CyrusNajmabadi removed their assignment Dec 15, 2021
@jasonmalinowski
Copy link
Member

@CyrusNajmabadi @sharwell Should we just close this then? Or if there's still pending work, what is it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure Integration-Test Test failures in roslyn-integration-CI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants