-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ServiceHub core host integration test CI #57228
Conversation
pool: | ||
name: NetCorePublic-Pool | ||
queue: $(queueName) | ||
timeoutInMinutes: 135 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding a matrix so we test both Release and Debug configurations. See example
roslyn/azure-pipelines-integration.yml
Lines 18 to 44 in e1b5726
- job: VS_Integration | |
pool: | |
name: $(poolName) | |
queue: $(queueName) | |
strategy: | |
maxParallel: 4 | |
matrix: | |
debug_32: | |
_configuration: Debug | |
_oop64bit: false | |
debug_64: | |
_configuration: Debug | |
_oop64bit: true | |
release_32: | |
_configuration: Release | |
_oop64bit: false | |
release_64: | |
_configuration: Release | |
_oop64bit: true | |
timeoutInMinutes: 135 | |
steps: | |
- template: eng/pipelines/test-integration-job.yml | |
parameters: | |
configuration: $(_configuration) | |
oop64bit: $(_oop64bit) | |
lspEditor: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to use $(poolName)
in this new leg as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That isn't necessary. We use that for our scouting queue.
Co-authored-by: Joey Robichaud <joseph.robichaud@microsoft.com>
@JoeRobich The new CI pipeline seems to be working as expected. Should I go ahead and merge this? How can I make sure the new core host legs are not blocking PRs? |
@JoeRobich Merge is blocked by flaky integration tests. Could you force merge this please? I believe the change in shared files is validated by (failed) integration test runs. Thanks! |
Thanks! @JoeRobich |
This depends on the change in #57223