Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More global:: scenarios #44019

Closed
333fred opened this issue May 6, 2020 · 1 comment
Closed

More global:: scenarios #44019

333fred opened this issue May 6, 2020 · 1 comment
Assignees
Labels
4 - In Review A fix for the issue is submitted for review. Area-Compilers Bug Urgency-Now
Milestone

Comments

@333fred
Copy link
Member

333fred commented May 6, 2020

The fix for #43960 didn't cover all scenarios this can occur, and the VS build is still failing. An example:

namespace N
{
    class C
    {
        void M(object o)
        {
            if (o is global::N.C) { }
        }
    }
}
@gafter
Copy link
Member

gafter commented May 6, 2020

Here is a repro:

        [Fact, WorkItem(44019, "https://github.com/dotnet/roslyn/issues/44019")]
        public void NamespaceQualifiedEnumConstantInIsPattern_03()
        {
            var source =
@"namespace E
{
    public class A { }
}

class Class1
{
    void M(object e)
    {
        if (e is global::E.A) { }
    }
}";
            CreateCompilation(source, parseOptions: TestOptions.Regular7, options: TestOptions.ReleaseDll).VerifyDiagnostics(
                );
            CreatePatternCompilation(source, options: TestOptions.ReleaseDll).VerifyDiagnostics(
                );
        }

@gafter gafter added the 4 - In Review A fix for the issue is submitted for review. label May 6, 2020
@ghost ghost closed this as completed in a83e3c3 May 7, 2020
333fred added a commit to 333fred/roslyn that referenced this issue May 7, 2020
* upstream/master:
  Implement ForceComplete in TupleFieldSymbol (dotnet#44042)
  Cache export provider factories
  Add instructions for demo'ing compiler toolset (dotnet#43992)
  Add addtional generic tests.
  Fix regression using alias qualified name in an is-type expression Fixes dotnet#44019
  Update src/VisualStudio/Core/Def/Implementation/ProjectSystem/VisualStudioAnalyzer.cs
  Use a shared shadow copy assembly loader for all VisualStudioAnalyzer instances
  Fix declared dependencies of Microsoft.VisualStudio.LanguageServices
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - In Review A fix for the issue is submitted for review. Area-Compilers Bug Urgency-Now
Projects
None yet
Development

No branches or pull requests

2 participants