Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename via the new renamer API should dismiss renaming tracking #44469

Open
davkean opened this issue May 21, 2020 · 3 comments
Open

Rename via the new renamer API should dismiss renaming tracking #44469

davkean opened this issue May 21, 2020 · 3 comments

Comments

@davkean
Copy link
Member

davkean commented May 21, 2020

After renaming a type to match the class name, the type gets treated as if it was manually renamed and enters a confusing behavior where I get a code fix to perform the rename that I just performed.

Steps to Reproduce:

  1. Checkout and build GitHub/fix programmatic rename project-system#6179
  2. Create new Console App (.NET Core) and rename Program.cs -> Bar.cs and say Yes to the prompt

Expected Behavior:
image

Actual Behavior:
image

Legacy does not run into this because it uses CodeModel to rename which dismisses the tracking here: http://sourceroslyn.io/#Microsoft.VisualStudio.LanguageServices.Implementation/CodeModel/AbstractCodeModelService.cs,505.

//cc @ryzngard @ocallesp

@ryzngard
Copy link
Contributor

Thanks! Looking

@CyrusNajmabadi
Copy link
Member

@ryzngard still needed?

@ryzngard
Copy link
Contributor

ryzngard commented Nov 1, 2022

Yes, but it's low pri work right now. User experience is a bug, but manageable and low impact.

@CyrusNajmabadi CyrusNajmabadi assigned Cosifne and unassigned ryzngard Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants