Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RenameDocument does not fire IVSRefactorNotify or dismiss rename tracking #47048

Closed
ryzngard opened this issue Aug 21, 2020 · 4 comments
Closed

RenameDocument does not fire IVSRefactorNotify or dismiss rename tracking #47048

ryzngard opened this issue Aug 21, 2020 · 4 comments
Assignees
@ryzngard
Labels
Area-IDE Bug Feature - Rename IDE-CodeStyle Built-in analyzers, fixes, and refactorings
Milestone
Backlog

Comments

@ryzngard
Copy link
Contributor

The new RenameDocumentAsync API regresses behavior by not handling IVSRefactorNotify or dismissing rename tracking.

These actions should happen on Workspace.TryApplyChanges from the solution produced by the API
@ryzngard ryzngard added this to the 16.8.P3 milestone Aug 21, 2020
@ryzngard ryzngard self-assigned this Aug 21, 2020
@ryzngard
Copy link
Contributor Author

ping @davkean @ocallesp , planning on 16.8 P3 for this fix

@jinujoseph jinujoseph added Bug IDE-CodeStyle Built-in analyzers, fixes, and refactorings labels Aug 25, 2020
This was referenced Sep 9, 2020
Closed
Closed
@jinujoseph jinujoseph modified the milestones: 16.8.P3, 16.8 Sep 10, 2020
@ryzngard
Copy link
Contributor Author

Rename tracking dismiss will be tracked as #44469 and fixed separately. Using this issue only for IVSRefactorNotify

@ryzngard ryzngard modified the milestones: 16.8, 16.9 Nov 12, 2020
@jinujoseph jinujoseph modified the milestones: 16.9, 16.10 Mar 28, 2021
@jinujoseph jinujoseph modified the milestones: 16.10, Backlog Jul 16, 2021
@ryzngard ryzngard mentioned this issue Jul 21, 2021
Closed
@CyrusNajmabadi
Copy link
Member

The new RenameDocumentAsync API regresses behavior by not handling IVSRefactorNotify or dismissing rename tracking.

FWIW, i'm 100% ok with this. IVsRefactorNotify is an awful API taht i would like us to get off of. For our new async rename entrypoints, i don't think we should use it. And features that need this information need to modernize to something better.

@CyrusNajmabadi
Copy link
Member

Closing out as speculative. No movement on this in 4 years means we don't need this.

@CyrusNajmabadi CyrusNajmabadi closed this as not planned Won't fix, can't repro, duplicate, stale Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryzngard ryzngard

Labels
Area-IDE Bug Feature - Rename IDE-CodeStyle Built-in analyzers, fixes, and refactorings
Projects
None yet
Milestone
Backlog
4 participants
@ryzngard @CyrusNajmabadi @vatsalyaagrawal @jinujoseph