Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review visibility of compilation options #44809

Closed
tmat opened this issue Jun 3, 2020 · 1 comment · Fixed by #50968
Closed

Review visibility of compilation options #44809

tmat opened this issue Jun 3, 2020 · 1 comment · Fixed by #50968
Assignees
Milestone

Comments

@tmat
Copy link
Member

tmat commented Jun 3, 2020

There are multiple comments in CompilationOptions.cs such as:

// TODO: change visibility of the ReferencesSupersedeLowerVersions setter to internal & protected

and properties with odd names like:

 internal DateTime CurrentLocalTime_internal_protected_set { set { CurrentLocalTime = value; } }
  internal bool DebugPlusMode_internal_protected_set { set { DebugPlusMode = value; } }

DebugPlusMode should also be public - it would make sense as a third value of OptimizationLevel rather then a separate property.
This is needed so that a tool can be written that reconstructs a compilation from DLL/PDB using public APIs only.

@tmat
Copy link
Member Author

tmat commented Jun 3, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants