Rebuild Microsoft.CodeAnalysis #50968

RikkiGibson · 2021-02-02T23:44:02Z

RikkiGibson · 2021-02-09T00:20:25Z

src/Compilers/CSharp/Test/Emit/PDB/PDBAsyncTests.cs

-2: nil
-3: nil
-4:
+================================================


This change (and similar changes in other tests) were required due to the mdv version update.

RikkiGibson · 2021-02-09T00:22:54Z

src/Tools/ManifestGenerator/Program.cs

+    internal const int ExitFailure = 1;
+    internal const int ExitSuccess = 0;
+
+    public static int Main(string[] args)


This new project is just a stub.

RikkiGibson · 2021-02-09T00:23:52Z

@ryzngard @jaredpar Please review. Feel free to give me a ping if you'd like me to walk through the changes.

jaredpar

Number of TODO and PROTOTYPE comments here. How are we planning on addressing them?

eng/targets/Services.props

eng/test-rebuild.ps1

src/Compilers/Core/Portable/Compilation/CompilationOptions.cs

jaredpar · 2021-02-09T00:52:55Z

src/Compilers/Core/Portable/Microsoft.CodeAnalysis.csproj

@@ -11,7 +11,8 @@
    <NoStdLib>true</NoStdLib>
    <ApplyNgenOptimization Condition="'$(TargetFramework)' == 'netstandard2.0'">partial</ApplyNgenOptimization>
    <GeneratePerformanceSensitiveAttribute>true</GeneratePerformanceSensitiveAttribute>
-
+    <EmbedUntrackedSources>true</EmbedUntrackedSources>


This is a temporary change correct? The idea being that when we are done with this effort that we will be adding this to Directory.Build.props? If so are we tracking that in an issue, comment, etc ...?

Filed #51099 to track. There is a bug in wpf temp projects that prevent us from enabling this in Settings.props or Directory.Build.props for now (is one or the other preferred? Directory.Build.props seemed pretty empty.)

I should probably file the bug to get this property fixed with WPF projects. Do you know the right repo to do that in? Maybe @clairernovotny knows? It seems not so bad to exclude those projects from rebuilding for a while though.

The WPF issues with targets/props and source link should all be fixed by setting IncludePackageReferencesDuringMarkupCompilation to true in the Directory.Build.Props file and using a 5.0.200+ SDK to build. This enables fixes within the WPF targets that are currently opt-out.

src/Compilers/Core/Portable/PEWriter/MetadataWriter.PortablePdb.cs

src/ExpressionEvaluator/Core/Test/ExpressionCompiler/ExpressionCompilerTestHelpers.cs

src/Tools/BuildValidator/BuildConstructor.cs

src/Tools/BuildValidator/BuildValidator.csproj

RikkiGibson · 2021-02-09T19:13:53Z

Number of TODO and PROTOTYPE comments here. How are we planning on addressing them?

Opened #51097 to track

eng/test-rebuild.ps1

src/Tools/BuildValidator/BuildConstructor.cs

jaredpar · 2021-02-09T21:09:26Z

src/Tools/BuildValidator/BuildValidator.csproj

    <Nullable>enable</Nullable>
+    <AllowUnsafeBlocks>true</AllowUnsafeBlocks>


Maybe I read right past it but where do we use unsafe code?

roslyn/src/Tools/BuildValidator/CompilationDiff.cs

Line 145 in 3f395ac

fixed (byte* ptr = rebuildBytes)

src/Tools/BuildValidator/LocalReferenceResolver.cs

src/Tools/BuildValidator/SourceLink.cs

ryzngard · 2021-02-09T23:50:42Z

src/Compilers/Core/Portable/PEWriter/MetadataWriter.PortablePdb.cs

-            WriteValue(CompilationOptionNames.SourceFileCount, module.CommonCompilation.SyntaxTrees.Count().ToString());
-
-            if (module.EmitOptions.FallbackSourceFileEncoding != null)
+            if (pdbCompilationOptionsReader is { } reader)


this looks like a very clear split of two methods

src/Tools/BuildValidator/CompilationDiff.cs

ryzngard · 2021-02-10T00:02:20Z

src/Tools/BuildValidator/CompilationOptionsReader.cs

    internal class CompilationOptionsReader
    {
+        public static readonly Guid HashAlgorithmSha1 = unchecked(new Guid((int)0xff1816ec, (short)0xaa5e, 0x4d10, 0x87, 0xf7, 0x6f, 0x49, 0x63, 0x83, 0x34, 0x60));


Is this copied from somewhere?

@ryzngard Yep.

roslyn/src/Compilers/Core/Portable/Debugging/SourceHashAlgorithms.cs

Lines 16 to 19 in afd1030

internal static class SourceHashAlgorithms

{

private static readonly Guid s_guidSha1 = unchecked(new Guid((int)0xff1816ec, (short)0xaa5e, 0x4d10, 0x87, 0xf7, 0x6f, 0x49, 0x63, 0x83, 0x34, 0x60));

private static readonly Guid s_guidSha256 = unchecked(new Guid((int)0x8829d00f, 0x11b8, 0x4213, 0x87, 0x8b, 0x77, 0x0e, 0x85, 0x97, 0xac, 0x16));

fwiw if these need to be the same, a note about the source is a good comment :)

Should I just rely on the definitions in SourceHashAlgorithms.cs and delete the copies of them in CompilationOptionsReader.cs? That requires the IVT to the compiler, but maybe it is reasonable to assume that IVT will be around indefinitely. What do you think @jaredpar?

Do they need to be the same, or is there some other reason these magical numbers work?

Rather than IVT can we just use a shared source approach?

The HashAlgorithm is a real part of the portable PDB spec. https://github.com/dotnet/corefx/blob/master/src/System.Reflection.Metadata/specs/PortablePdb-Metadata.md#document-table-0x30

I'll look into sharing source when I get the chance. Perhaps looking at the prior art in Workspaces, etc. will make it clear how I should do this.

oh, just noting that it's part of the Portable PDB spec would be a great way to demystify this. I don't think sharing code would be needed

jaredpar

Nit: I'd change all the PROTOTYPE to TODO since generally we try and avoid PROTOTYPE on the main branches.

jaredpar · 2021-02-10T01:29:55Z

src/Tools/BuildValidator/BuildConstructor.cs

+                return result;
+            }
+
+            string GetUniqueOption(string name)


Nit: local functions are jumping between pascal and CamelCase.

src/Tools/BuildValidator/CompilationDiff.cs

azure-pipelines.yml

src/Tools/BuildValidator/BuildConstructor.cs

src/Tools/BuildValidator/LocalSourceResolver.cs

src/Tools/BuildValidator/LocalReferenceResolver.cs

jaredpar · 2021-02-17T00:06:30Z

src/Tools/BuildValidator/CompilationDiff.cs

-                using var originalStream = assemblyFile.OpenRead();
-                var originalBytes = new byte[originalStream.Length];
-                originalStream.Read(originalBytes, 0, (int)originalStream.Length);
+            using var win32ResourceStream = producedCompilation.CreateDefaultWin32Resources(


Can you add a comment as to why we are doing this. Essentially "by default command line adds a resource that we need to replicate manually here".

sounds good. BTW, should we try extracting and copying over this resource from the original assembly?

jaredpar · 2021-02-17T00:08:56Z

src/Tools/BuildValidator/DemoLogger.cs

+
+namespace BuildValidator
+{
+    internal sealed class DemoLogger : ILogger


Can we add a TODO of either we should use the real logger or not log at all? I added this just for the Demo cause I couldn't figure out some issues with the default logger. Fine for this to go in now but think we need a TODO tracking cleaning this up.

src/Tools/BuildValidator/LocalReferenceResolver.cs

src/Tools/BuildValidator/SourceLink.cs

src/Tools/BuildValidator/BuildConstructor.cs

Co-authored-by: Jared Parsons <jaredpparsons@gmail.com>

src/Tools/BuildValidator/CompilationDiff.cs

src/Tools/BuildValidator/LocalReferenceResolver.cs

src/Tools/BuildValidator/Program.cs

jcouv · 2021-02-17T21:01:28Z

src/Tools/ManifestGenerator/README.md

@@ -0,0 +1,4 @@
+# dotnet-roslyn-manifest-generator
+
+https://github.com/dotnet/roslyn/blob/efd69176d6ad7f9dbe1d87525201760a6c44e7a0/docs/compilers/terrapin.md#artifacts-manifest-file


nit: is there a permanent link we could use instead?

@jcouv Isn't this already a permanent link?

Once Jared's changes in #49886 are merged, we will probably link to the document in-repo, possibly with a summary of the relevant section in here.

tmat · 2021-02-17T23:22:53Z

azure-pipelines.yml

+        arguments: -configuration Debug -prepareMachine -ci -build -bootstrap -publish -binaryLog -skipDocumentation
+
+    - script: .\artifacts\bin\BuildValidator\Debug\net472\BuildValidator.exe --assembliesPath .\artifacts\obj\Microsoft.CodeAnalysis --debugPath .\artifacts\BuildValidator --sourcePath .
+      displayName: Run BuildValidator


It'd be better to have this logic in a eng/validate-rebuild.ps1 file, so it can be easily run locally.

Actually, why not call test-rebuild.ps1?

In reply to: 578014609 [](ancestors = 578014609)

commit 3ee6a8fea776de589329d6298df0dd80109bea3b Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Date: Sat Feb 20 01:02:58 2021 +0000 Update dependencies from https://github.com/dotnet/arcade build 20210218.7 (#51334) [master] Update dependencies from dotnet/arcade commit 1955f409bf199a8359e688ff81771fc49ef5d5cb Author: Bernd Baumanns <baumannsbernd@gmail.com> Date: Fri Feb 19 23:27:36 2021 +0100 Fix NormalizeWhitespace - String Interpolation with e.g. Initializer-expressions (#51213) Co-authored-by: CyrusNajmabadi <cyrus.najmabadi@gmail.com> Co-authored-by: Bernd Baumanns <familiebaumanns@googlemail.com> commit 87ce1bf93fbc52ff09dbf2c6cd8b0d1603b6f652 Merge: 7b604ab85fe 007046dce89 Author: msftbot[bot] <48340428+msftbot[bot]@users.noreply.github.com> Date: Fri Feb 19 22:06:17 2021 +0000 Merge pull request #51275 from jaredpar/log Provide structured information in binlog for the compiler server commit 7b604ab85fe0b585c3fd54548e0d5566359bdfb5 Merge: d402ca87e09 2455535bd80 Author: Sam Harwell <sam.harwell@microsoft.com> Date: Fri Feb 19 12:47:07 2021 -0800 Merge pull request #51244 from sharwell/failed-save Handle failed SaveAsync operations commit 007046dce893b887d48d1a635f8c746af30c9c8f Author: Jared Parsons <jaredpparsons@gmail.com> Date: Fri Feb 19 12:45:21 2021 -0800 PR feedback commit 073598befa473d80c4e4ce167146d6eebf8da25d Author: Jared Parsons <jaredpparsons@gmail.com> Date: Fri Feb 19 12:43:52 2021 -0800 Apply suggestions from code review Co-authored-by: Rikki Gibson <rikkigibson@gmail.com> commit d402ca87e09b075d753e0056cb360ea4a551c480 Merge: be8c0569b42 3ee164faeff Author: Sam Harwell <sam.harwell@microsoft.com> Date: Fri Feb 19 12:43:18 2021 -0800 Merge pull request #51332 from sharwell/supported-lang Avoid capture allocation in AnalyzerFileReference.GetSupportedLanguages commit be8c0569b42ac0d4574cb0911fea25ad73ff0ba7 Author: Youssef Victor <31348972+Youssef1313@users.noreply.github.com> Date: Fri Feb 19 21:26:57 2021 +0200 Check reference equality for strongly-typed equals in records (#51149) commit b427e9272d66c69845af5840b27714469374a709 Merge: 121e4b43bca 7451b6089e3 Author: msftbot[bot] <48340428+msftbot[bot]@users.noreply.github.com> Date: Fri Feb 19 19:18:35 2021 +0000 Merge pull request #51341 from dotnet/merges/release/dev16.10-to-master Merge release/dev16.10 to master commit 7451b6089e3fd3a22de2eeb102a2d06443be08a9 Merge: 45d0aaefa85 986663a7c1e Author: Shen Chen <Cosifne@users.noreply.github.com> Date: Fri Feb 19 09:38:55 2021 -0800 Merge pull request #50623 from Cosifne/dev/shech/AutolineEnder Expand Edit.SmartBreakline to cover more scenario commit 4aed0dbf37017acc8486876ffe89d777d03cdb2b Author: Jared Parsons <jaredpparsons@gmail.com> Date: Fri Feb 19 08:57:55 2021 -0800 Apply suggestions from code review Co-authored-by: Sam Harwell <sam@tunnelvisionlabs.com> commit 121e4b43bcaac109a960f859f42d972f7d35b803 Merge: a525c5fbeae 2aa1c3fa73c Author: Sam Harwell <sam.harwell@microsoft.com> Date: Fri Feb 19 07:56:00 2021 -0800 Merge pull request #51330 from sharwell/get-option-core Optimize option lookup allocations commit 986663a7c1eb0c93edab01b61ace718633805de6 Author: Shen Chen <cos_ifne@hotmail.com> Date: Thu Feb 18 22:35:40 2021 -0800 Add another test for object creation commit 3ee164faefff4992d90e2f084f3185f2dd6d1a4a Author: Sam Harwell <Sam.Harwell@microsoft.com> Date: Thu Feb 18 20:53:13 2021 -0800 Avoid capture allocation in AnalyzerFileReference.GetSupportedLanguages commit 2aa1c3fa73c343f0f6b0444a8d46850fffbb2b98 Author: Sam Harwell <Sam.Harwell@microsoft.com> Date: Thu Feb 18 20:27:19 2021 -0800 Avoid allocating an OfType iterator for SingleOrDefault commit fa54455a67673edd74c4c9702d72ca80793823d0 Author: Sam Harwell <Sam.Harwell@microsoft.com> Date: Thu Feb 18 20:25:25 2021 -0800 Avoid delegate creation for each use of GetOptionCore commit a525c5fbeaef989f114c2def83c6ce48497ac695 Author: Julien Couvreur <jcouv@users.noreply.github.com> Date: Thu Feb 18 19:04:10 2021 -0800 Avoid double declaration of switch expression variables in PDB symbols (#51055) commit b762ff23c50fd8087c3c51b637fdfd096dd7bbad Merge: 16124d62675 a5f1b032889 Author: CyrusNajmabadi <cyrus.najmabadi@gmail.com> Date: Thu Feb 18 17:42:22 2021 -0800 Merge pull request #51138 from CyrusNajmabadi/asyncProjectFactory Expose async entrypoint for IWorkspaceProjectContextFactory commit 16124d62675fb5a3012b7e4641835cb123f23677 Merge: d294fd7076d 45d0aaefa85 Author: msftbot[bot] <48340428+msftbot[bot]@users.noreply.github.com> Date: Fri Feb 19 01:37:35 2021 +0000 Merge pull request #51323 from dotnet/merges/release/dev16.10-to-master Merge release/dev16.10 to master commit d294fd7076de7778199d6d594bb288ec17286b37 Author: AlekseyTs <AlekseyTs@users.noreply.github.com> Date: Thu Feb 18 16:14:10 2021 -0800 Add Global Using Directive to language feature status (#51308) commit 7a16b118a4540a79adcca9d90a4d7d2817c276d9 Merge: 2fffa44d198 b4c8219c6e2 Author: msftbot[bot] <48340428+msftbot[bot]@users.noreply.github.com> Date: Thu Feb 18 23:31:10 2021 +0000 Merge pull request #51317 from CyrusNajmabadi/removeInternalDep Remove dependency on internal VS utility apis. commit 45d0aaefa85a85cb9f429b13a344db22fdf1f9d6 Merge: 3b081504614 ca8abf7aa16 Author: msftbot[bot] <48340428+msftbot[bot]@users.noreply.github.com> Date: Thu Feb 18 22:28:15 2021 +0000 Merge pull request #51315 from dotnet/merges/release/dev16.9-to-release/dev16.10 Merge release/dev16.9 to release/dev16.10 commit a85c119b78c5544242247318d452c47a5679555d Author: Shen Chen <cos_ifne@hotmail.com> Date: Thu Feb 18 14:24:59 2021 -0800 Fix a formatting error commit b4c8219c6e282cfe82ea07c68d5e0f5e36193fab Author: CyrusNajmabadi <cyrus.najmabadi@gmail.com> Date: Thu Feb 18 14:21:19 2021 -0800 Update src/VisualStudio/Core/Def/Implementation/LanguageClient/InProcLanguageServer.cs commit 1f0a0fec484a8591d8567ccc235b54952d504bef Author: Shen Chen <cos_ifne@hotmail.com> Date: Thu Feb 18 13:59:05 2021 -0800 Clean the code commit 800f390040375f38220ed4cf836b6e42fde6d7c4 Author: Shen Chen <cos_ifne@hotmail.com> Date: Thu Feb 18 13:43:18 2021 -0800 Add more comments commit 15dd43e61964b42120a8750421c4b3c9f964e90c Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Thu Feb 18 13:21:19 2021 -0800 Simplify commit 2fffa44d1981ca2abccdfed8284af16848c70cb4 Author: Marco Goertz <mgoertz@microsoft.com> Date: Thu Feb 18 13:05:09 2021 -0800 Experimental XAML LSP client (#51296) * Create second XAML LSP client without DisableUserExperience set and toggle between them via feature flag * Share capabilities between the clients commit fe367718b757a3fe4b3127f37cbe98e8661ff8c7 Author: Shen Chen <cos_ifne@hotmail.com> Date: Thu Feb 18 13:03:26 2021 -0800 Fix the if and else case commit 6a8ff257cc1a6581bcc35b5410aeb179f4b32d11 Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Thu Feb 18 12:34:17 2021 -0800 Remove dependency on internal VS utility apis. commit 5da5c2ee7f970856aec227134c870b9f0f5e4521 Merge: 60c8eb664ea 4506df7a392 Author: Sam Harwell <sam.harwell@microsoft.com> Date: Thu Feb 18 12:50:54 2021 -0800 Merge pull request #51065 from sharwell/formatter-loh Use segmented collections to avoid LOH allocations in the formatter commit ca8abf7aa167da9ba9a00bc01cddd7d53d759991 Merge: 6a62ceb9741 da6c1006a5e Author: Joey Robichaud <jorobich@microsoft.com> Date: Thu Feb 18 12:31:36 2021 -0800 Merge pull request #51313 from JoeRobich/fix-integration-tests Revert ToggleCompletionMode command name to its canonical name commit 4506df7a392d9474868e8591ad6c9235ff17e216 Author: Sam Harwell <Sam.Harwell@microsoft.com> Date: Sun Feb 7 21:52:53 2021 -0800 Use a segmented list to avoid LOH allocations in the formatter commit da6c1006a5e15179738452547f0f9acb5676e877 Author: Joey Robichaud <joseph.robichaud@microsoft.com> Date: Thu Feb 18 11:07:15 2021 -0800 Revert ToggleCompletionMode command name to its canonical name commit 9acd89794c4a79b50a8270e82b603ac5d1668719 Author: Jared Parsons <jaredpparsons@gmail.com> Date: Thu Feb 18 10:30:45 2021 -0800 Better log message commit 60c8eb664ea772cfa6dbc3859b5d4683fd4fc709 Author: Jared Parsons <jaredpparsons@gmail.com> Date: Thu Feb 18 10:14:48 2021 -0800 Initial draft of the Terrapin plan (#49886) * Initial draft of the Terrapin plan This is an initial draft of the plan for how the .NET Roslyn team will be delivering tools for provenance validation to the Terrapin team. The goal of these tools is to allow Terrapin, and eventually any .NET customer, to determine the provenance of PE file in .NET. Provenance effectively means can it be re-built deterministically using the information stored in the PDB and the source files referenced via the embedded source link information. DLLs / EXEs which can achieve this are guaranteed to be rebuildable from source as well as being able to concretely document their build inputs. * PR feedback * Apply suggestions from code review Co-authored-by: Rikki Gibson <rikkigibson@gmail.com> Co-authored-by: Rikki Gibson <rikkigibson@gmail.com> commit b178e23743bc76d2a3936aa6f765cbfde69a908d Author: Shen Chen <cos_ifne@hotmail.com> Date: Thu Feb 18 00:49:40 2021 -0800 Fix the caret position when remove parenthesis commit 71129f50661031a5d617bcb0bfabe5743449cb33 Author: Fred Silberberg <frsilb@microsoft.com> Date: Thu Feb 18 09:54:48 2021 -0800 Add list patterns to language feature status (#51290) commit a4bdff76ec342a445d6c59025df96f55688cb8d5 Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Date: Thu Feb 18 14:39:54 2021 +0000 Update dependencies from https://github.com/dotnet/arcade build 20210216.3 (#51306) [master] Update dependencies from dotnet/arcade commit e443c5d6ce1d1cf9ffd9da9d76b9eac1a087c6e2 Author: Shen Chen <cos_ifne@hotmail.com> Date: Wed Feb 17 19:54:32 2021 -0800 Add more tests commit 724452a2462e7b67ab1a6b538106004f1fa4edae Merge: 1209b911127 e5b48ea5181 Author: msftbot[bot] <48340428+msftbot[bot]@users.noreply.github.com> Date: Thu Feb 18 03:44:14 2021 +0000 Merge pull request #51284 from CyrusNajmabadi/moveRecord Fix issue with 'move type to file' when moving a record. commit 1209b911127965e2f6e695956629ccdfd5dfc3fa Merge: adfd99fb915 ca2505a08c8 Author: CyrusNajmabadi <cyrus.najmabadi@gmail.com> Date: Wed Feb 17 19:34:04 2021 -0800 Merge pull request #51283 from CyrusNajmabadi/farConversion Add support for finding explicit conversion operators that are directly callled commit a5f1b032889f14c863ff2a09bc15de0ebc6b2fc2 Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Wed Feb 17 19:24:30 2021 -0800 REvise commit b1e2a6bd7991ea968ad1cb476ad35275e9003a76 Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Wed Feb 17 19:20:30 2021 -0800 Revert commit 4bc6c1cfd405b3f793d878892d378a25ef3f8dbf Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Wed Feb 17 19:17:54 2021 -0800 Docs commit 6285480e235fe4adc0ef00fb4daee7192109f9ff Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Wed Feb 17 19:11:46 2021 -0800 Tweak commit c7d437266191e36a307e1b7e6d319dadb3b23584 Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Wed Feb 17 18:58:10 2021 -0800 Move comment commit c701b66ef0ceb0b9e06d021737120b8adb0ac6aa Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Wed Feb 17 18:56:16 2021 -0800 rename commit c73e66b02315ba14786c50de796fe4cfafe23db9 Author: CyrusNajmabadi <cyrus.najmabadi@gmail.com> Date: Wed Feb 17 18:55:28 2021 -0800 Update src/VisualStudio/Core/Def/Implementation/ProjectSystem/VisualStudioProjectFactory.cs Co-authored-by: Jason Malinowski <jason@jason-m.com> commit 5f3c213c05ded0fb6cdb3b5dca430b200552766f Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Wed Feb 17 18:54:52 2021 -0800 reorder commit 56a0fc9dd0ea08be421eda56e0865166637c48c4 Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Wed Feb 17 18:53:18 2021 -0800 Switch back to UIthread commit adfd99fb915d5943843e2090243757024007b459 Merge: a2da53d0e74 3b081504614 Author: msftbot[bot] <48340428+msftbot[bot]@users.noreply.github.com> Date: Thu Feb 18 02:52:41 2021 +0000 Merge pull request #51291 from dotnet/merges/release/dev16.10-to-master Merge release/dev16.10 to master commit e5b48ea518150c842486a8692b393b9f34d33848 Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Wed Feb 17 18:30:40 2021 -0800 Cleanup implementation. commit 9da1017b50364dbe1a98aa127fea03311a8c16c0 Author: Shen Chen <cos_ifne@hotmail.com> Date: Wed Feb 17 17:06:13 2021 -0800 Move code to helper commit a2da53d0e741e3160e9e3d4e63ebd7624f7f0843 Author: Fred Silberberg <frsilb@microsoft.com> Date: Wed Feb 17 17:00:50 2021 -0800 Added test for custom modifier substitution in function pointer types. (#51038) commit 6171900dad45fa49de23911557d70905460d5514 Merge: 876f817dc92 e78bfe0e458 Author: msftbot[bot] <48340428+msftbot[bot]@users.noreply.github.com> Date: Thu Feb 18 00:18:33 2021 +0000 Merge pull request #51288 from CyrusNajmabadi/recordKeyword Fix a couple of cases where 'record' was not being offered. commit 876f817dc9214e98debda899d1c3d8b600be93cb Merge: 468b14ebc8e 0b318c81539 Author: msftbot[bot] <48340428+msftbot[bot]@users.noreply.github.com> Date: Wed Feb 17 23:51:25 2021 +0000 Merge pull request #51285 from dotnet/merges/release/dev16.10-to-master Merge release/dev16.10 to master commit 468b14ebc8e4307de2a4586748dd4852e156938e Author: Fred Silberberg <frsilb@microsoft.com> Date: Wed Feb 17 15:30:10 2021 -0800 Add IMethodSymbol.IsPartialDefinition (#51255) commit bf2a49d13b50ba62604d4a3b063dd3446ff98f77 Author: Rikki Gibson <rigibson@microsoft.com> Date: Wed Feb 17 15:11:20 2021 -0800 Rebuild Microsoft.CodeAnalysis (#50968) Co-authored-by: Jared Parsons <jaredpparsons@gmail.com> commit 3b0815046148d4b23f177987917e7b4ccbe7a017 Merge: 0b318c81539 6a62ceb9741 Author: msftbot[bot] <48340428+msftbot[bot]@users.noreply.github.com> Date: Wed Feb 17 23:01:57 2021 +0000 Merge pull request #51279 from dotnet/merges/release/dev16.9-to-release/dev16.10 Merge release/dev16.9 to release/dev16.10 commit b2722063833970d06380e3fb012ac67520701974 Author: AlekseyTs <AlekseyTs@users.noreply.github.com> Date: Wed Feb 17 14:51:30 2021 -0800 Remove an obsolete doc comment. (#51270) commit e78bfe0e458aec17e0375cf08e277c0f1a1a9e8f Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Wed Feb 17 14:45:58 2021 -0800 Revert commit 38790b87e2da797e8d3c664bacd847bc62056e03 Author: CyrusNajmabadi <cyrus.najmabadi@gmail.com> Date: Wed Feb 17 14:44:54 2021 -0800 Update src/Workspaces/SharedUtilitiesAndExtensions/Workspace/CSharp/Extensions/ContextQuery/SyntaxTreeExtensions.cs commit 1618a62e57dee42609a4164e5de4cbde2e02f612 Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Wed Feb 17 14:42:18 2021 -0800 Fix a couple of cases where 'record' was not being offered. commit da5eff4e6ccb22ec577aab3a55deb6756c030be7 Author: CyrusNajmabadi <cyrus.najmabadi@gmail.com> Date: Wed Feb 17 14:42:33 2021 -0800 Update src/Features/Core/Portable/CodeRefactorings/MoveType/AbstractMoveTypeService.MoveTypeEditor.cs Co-authored-by: Joey Robichaud <joseph.robichaud@microsoft.com> commit 0b318c815391a1482f8bcb0835d1eb6dce97069f Merge: 73ecfd64fd7 9f05192910e Author: Joey Robichaud <jorobich@microsoft.com> Date: Wed Feb 17 14:35:02 2021 -0800 Merge pull request #51277 from JoeRobich/fix-test-1 Update ImmutableSegmentedDictionary KeyNotFound test to work regardless of locale commit 8b3c1147c6e75602f89e5d0eae77cc8fa9dedf36 Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Wed Feb 17 14:20:26 2021 -0800 Fix issue with 'move type to file' when moving a record. commit ca2505a08c8974dde3243bd9fdb6a159c3d83cd7 Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Wed Feb 17 13:28:24 2021 -0800 Add support for finding explicit conversion operators that are directly callled commit c19d151ee853be54723cd453bb47e991f2e6b356 Merge: b6e71ea7f34 dc94b6aea25 Author: Jason Malinowski <jason.malinowski@microsoft.com> Date: Wed Feb 17 13:24:33 2021 -0800 Merge pull request #50889 from jasonmalinowski/clean-up-editorfeatures-cocoa-structure-tags Unify our structure tag implementations and move to IStructureTag commit b6e71ea7f34984b8222ab4e9fe3a169c2f4a0b8a Merge: 877c074a2c5 9be7ce6bba4 Author: msftbot[bot] <48340428+msftbot[bot]@users.noreply.github.com> Date: Wed Feb 17 20:43:38 2021 +0000 Merge pull request #51276 from CyrusNajmabadi/fullyQualify Do not add 'static' keyword when fully qualifying using alias. commit 6a62ceb97412a56234c4bbf7a8b2ad87e17ca527 Merge: 70821a70d05 efa89274e2d Author: msftbot[bot] <48340428+msftbot[bot]@users.noreply.github.com> Date: Wed Feb 17 19:57:56 2021 +0000 Merge pull request #51272 from dotnet/merges/release/dev16.8-to-release/dev16.9 Merge release/dev16.8 to release/dev16.9 commit 274135c661481a0dcdccb817df365eb3c30dc4b8 Author: Shen Chen <cos_ifne@hotmail.com> Date: Wed Feb 17 11:13:02 2021 -0800 Append a new line after close brace commit 4469be043659f36ce1924fa6f91e86bdb352bd00 Author: Jared Parsons <jaredpparsons@gmail.com> Date: Wed Feb 17 11:18:15 2021 -0800 Structured server error messages This change adds structured messages to the binlog about the behavior of the compiler server. These messages will help users, our own developers and automation understand the behavior of the compiler server within a build. commit 9f05192910eaf079c0e9be41c801036ad38237a8 Author: Joey Robichaud <jorobich@microsoft.com> Date: Wed Feb 17 11:40:59 2021 -0800 Update ImmutableSegmentedDictionary KeyNotFound test to work regardless of locale commit 9be7ce6bba458e7d222774d440695b821c9ed595 Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Wed Feb 17 11:30:50 2021 -0800 Do not add 'static' keyword when fully qualifying using alias. commit 877c074a2c5dc2585041cd23cbed631badd31459 Merge: 3883c1d430e 01fed64c4b0 Author: Sam Harwell <sam.harwell@microsoft.com> Date: Wed Feb 17 10:53:01 2021 -0800 Merge pull request #51064 from sharwell/segmented-list Implement SegmentedList<T> commit 35ede681207860bc473b7e77c4b002545649accf Author: Shen Chen <cos_ifne@hotmail.com> Date: Wed Feb 17 10:44:05 2021 -0800 Update the tests commit efa89274e2d526e15481a127d21ef5986e15a234 Merge: 70821a70d05 58750fa12fc Author: Rikki Gibson <rigibson@microsoft.com> Date: Wed Feb 17 10:31:13 2021 -0800 Merge remote-tracking branch 'upstream/release/dev16.8' into merges/release/dev16.8-to-release/dev16.9 commit 58750fa12fca3f518407b1943c5de76af80fce1c Merge: dedcd5806b0 84b03a0b4b9 Author: Joey Robichaud <jorobich@microsoft.com> Date: Wed Feb 17 09:48:29 2021 -0800 Merge pull request #51094 from dotnet/feed-update-release/dev16.8 [release/dev16.8] NuGet Feed Update commit 3883c1d430e8109b5974fcea6137715b79ec7339 Author: Tomáš Matoušek <tmat@users.noreply.github.com> Date: Wed Feb 17 09:00:33 2021 -0800 Preparation for partial type support in EnC (#51253) * Test refactoring * Fix issues with double-update of an implicit constructor * EditAndContinueDocumentAnalysesCache * Remove declaration error checking in semantic analysis of members. This was added as a stop-gap measure to guard against unexpected error condition. It introduces dependency on partial declarations which is problematic wrt caching. It's actually not needed since the semantic analysis handles error symbols fine. Adds tests to validate. * Use ArrayBuilder/ImmutableArray.Builder instead of List/Array * Merge * Fixups * Check base project when reusing cached analysis results * Fix formatting commit 6371eee71ae560a7fafe142811619d3401b1b1f7 Author: Jared Parsons <jaredpparsons@gmail.com> Date: Wed Feb 17 08:56:45 2021 -0800 Clean up the error message path Refactor a bit and clean up some comments to help make the flow of data a bit clearer here. commit ca2ae8291b46c811ff9bffcc9bdc0e45fd553e53 Author: Jared Parsons <jaredpparsons@gmail.com> Date: Wed Feb 17 08:23:24 2021 -0800 Remove ErrorOutput The `ErrorOutput` field is not used in the compiler protocol because the compiler never writes to stderr. This was complicating the code path for no good reason and hence I decided to remove it. commit e95f7c7812fab7679b7f1c47165347a0185d7898 Author: Julien Couvreur <jcouv@users.noreply.github.com> Date: Wed Feb 17 07:53:00 2021 -0800 Register record-structs feature (#51247) commit d4911e8ecac125221580f6c9eae1a9c3fee0ff0a Author: AlekseyTs <AlekseyTs@users.noreply.github.com> Date: Wed Feb 17 06:18:12 2021 -0800 Restore the invariant that MembersAndInitializers do not have empty groups of sibling initializers. (#51142) Closes #50775. commit 717b204a853adbe291a0418d630e533893bbae47 Author: Rikki Gibson <rigibson@microsoft.com> Date: Tue Feb 16 18:18:30 2021 -0800 Update config for snap (#51258) commit dc94b6aea25ed9d84645bbaa1d5c74403ed16190 Author: Jason Malinowski <jason.malinowski@microsoft.com> Date: Tue Feb 16 17:58:06 2021 -0800 Tweak how we create header spans in VB This seems to fix some issues as well where we didn't show headers when hovering over some block indicators. Ideally we should be passing around the header span directly as a part of a BlockSpan but this I think helps maintain existing behavior as well. commit 120de1c63adc1cdd58566f31c144330c7f10c4d0 Author: Jason Malinowski <jason.malinowski@microsoft.com> Date: Tue Feb 16 10:58:31 2021 -0800 Update unit tests to also assert the header texts for structure tags commit 5569927a78edf11a2c20ec4c1203c613887260ac Author: Jason Malinowski <jason.malinowski@microsoft.com> Date: Fri Feb 12 17:57:56 2021 -0800 Use a xUnit theory for tests that are almost identical commit c337aead326a96751c2be4aeca4652c2b8015b20 Author: Jason Malinowski <jason.malinowski@microsoft.com> Date: Thu Jan 28 18:27:58 2021 -0800 Unify our structure tag implementations and move to IStructureTag Closes https://github.com/dotnet/roslyn/issues/26445 commit 4b790422b0ee69dd006d28badead0950865fb54b Merge: 214716a0058 0abcb5ba114 Author: msftbot[bot] <48340428+msftbot[bot]@users.noreply.github.com> Date: Wed Feb 17 02:00:27 2021 +0000 Merge pull request #51251 from CyrusNajmabadi/todoReporting Do not bother rereporting when we have no todo comments for a file commit 84b03a0b4b93e2b8d28644b7aad10fed6c3ded1e Author: Joey Robichaud <joseph.robichaud@microsoft.com> Date: Thu Feb 11 15:12:00 2021 -0800 Make msbuild workspace test conditional on VS16.9 Preview 3 commit 214716a00589eb37457035024fb217ce7cce8c75 Author: Rikki Gibson <rigibson@microsoft.com> Date: Tue Feb 16 17:15:31 2021 -0800 Include job attempt in log artifact name (#51249) commit 0abcb5ba11499a13790b52c1f7a585781d5d0d59 Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Tue Feb 16 15:04:36 2021 -0800 Fix comment commit ba63903c7c6a970c7efad1ce66c3d04e56b4d9a7 Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Tue Feb 16 15:03:15 2021 -0800 Fix comment commit 5b65a09ff69591332ef0685696f730299b690d9f Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Tue Feb 16 15:02:08 2021 -0800 Remove locking commit 73ecfd64fd710bd3b5c358ece3156f7f115ca5ba Merge: 4efe5c27438 b934a816b55 Author: Sam Harwell <sam.harwell@microsoft.com> Date: Tue Feb 16 15:00:50 2021 -0800 Merge pull request #50718 from dotnet/nimullen/razor.29547 Add EA.Razor APIs for breakpoint & proximity expression resolution. commit 9a2072a265921aa05416acd5322fa1eca4d64edf Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Tue Feb 16 14:53:20 2021 -0800 update comment commit 0c0f562e72b30188dc64a68925f34daaeb411af9 Merge: ba18a7d9f82 b276eb4573b Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Tue Feb 16 14:52:34 2021 -0800 Merge branch 'todoReporting' of https://github.com/CyrusNajmabadi/roslyn into todoReporting commit ba18a7d9f8288f6ca2934c735eb8631982e2e68e Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Tue Feb 16 14:51:53 2021 -0800 Invert set commit b276eb4573b47d23a383033d59b186dbb7a2db28 Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Tue Feb 16 14:51:53 2021 -0800 Invert set commit 4efe5c274381903fc1cb6e89eff5193356ea6643 Author: Tomáš Matoušek <tmat@users.noreply.github.com> Date: Tue Feb 16 14:43:12 2021 -0800 Adds benchmark updating a document with a new SourceText. (#51237) commit 99f4332e547aa6e7e18f2d1b84336e170c84e197 Merge: 5877dbad339 a68422011bf Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Tue Feb 16 14:41:16 2021 -0800 Simplify commit a68422011bfb4b563a0af415247ebbfea0ac486c Author: CyrusNajmabadi <cyrus.najmabadi@gmail.com> Date: Tue Feb 16 14:39:58 2021 -0800 Update src/Features/Core/Portable/TodoComments/AbstractTodoCommentsIncrementalAnalyzer.cs Co-authored-by: Sam Harwell <sam@tunnelvisionlabs.com> commit 5877dbad339ed91fff54ca8f3c141f7f95461713 Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Tue Feb 16 14:39:34 2021 -0800 Growth commit b042fb946ab8e61c6378b815c80e97732b632eff Author: CyrusNajmabadi <cyrus.najmabadi@gmail.com> Date: Tue Feb 16 14:32:59 2021 -0800 Update src/Features/Core/Portable/TodoComments/AbstractTodoCommentsIncrementalAnalyzer.cs Co-authored-by: Sam Harwell <sam@tunnelvisionlabs.com> commit 7e543b315b4a5352f3fe01a8dd4a07d4422c34db Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Tue Feb 16 14:25:13 2021 -0800 Do not bother rereporting when we have no todo comments for a file commit b934a816b55070822cfbc2f708c9358f21f1d8d1 Author: N. Taylor Mullen <nimullen@microsoft.com> Date: Tue Feb 16 12:34:28 2021 -0800 Update Razor EA API commit eba15413a9ab66b7e40db8cd53dbd8ec1285cae3 Author: Shen Chen <cos_ifne@hotmail.com> Date: Tue Feb 16 12:16:01 2021 -0800 Move add/remove braces function to helpers commit ea553e9c7ae41bf655196a9a09e842ce35aebcfa Author: N. Taylor Mullen <nimullen@microsoft.com> Date: Tue Feb 16 11:36:50 2021 -0800 Address code review feedback commit 2455535bd806c960726a8d1d9b5396b78e526b80 Author: Sam Harwell <Sam.Harwell@microsoft.com> Date: Tue Feb 16 09:40:32 2021 -0800 Link to dotnet/runtime#30878 instead of dotnet/roslyn#42178 commit 8a7ff2e9d89222eebef27da1f76d23de8887f2c1 Author: Sam Harwell <Sam.Harwell@microsoft.com> Date: Tue Feb 16 09:22:16 2021 -0800 Handle failed SaveAsync operations Fixes #31548 Fixes #42178 commit 1cbe495830e0ea42ae582bc3ae8b8dafb192ba96 Merge: 075e9c3e3e5 a0094b51296 Author: AlekseyTs <AlekseyTs@users.noreply.github.com> Date: Tue Feb 16 08:51:38 2021 -0800 Merge pull request #51242 from bschaeublin/patch-1 Fix redundant remark part in MetadataReference.CreateFromStream overload commit a0094b5129666d332c8b5b42d205dcb84956081c Author: Benjamin Schäublin <benjamin.schaeublin@cmiag.ch> Date: Tue Feb 16 09:15:53 2021 +0100 fix redundant text in remark commit c48a3c000126a586961c519a6f9bf6041f65f3b5 Author: Shen Chen <cos_ifne@hotmail.com> Date: Mon Feb 15 23:04:22 2021 -0800 Remove snippets commit 57d99df990976249cdbde2972c854ac75174d2c5 Author: Shen Chen <cos_ifne@hotmail.com> Date: Mon Feb 15 21:47:59 2021 -0800 Fetch newline string from editor options commit 075e9c3e3e57b150cfae938d4b652b9ee9c4171f Author: David Wengier <david.wengier@microsoft.com> Date: Tue Feb 16 17:47:22 2021 +1100 Fix NRE in Generate Constructor from VB (#51239) commit 0e845e10ade26278cee862e2afacbf1c30e3f0e6 Author: Shen Chen <cos_ifne@hotmail.com> Date: Mon Feb 15 11:52:48 2021 -0800 Refactor first check code commit dea7445650c22c8c10c05556cbdaddb3087caa42 Merge: 967c74b4e0d 25e740e13f4 Author: CyrusNajmabadi <cyrus.najmabadi@gmail.com> Date: Mon Feb 15 11:39:51 2021 -0800 Merge pull request #50524 from Youssef1313/patch-4 Support records in CSharpGenerateDefaultConstructorsService commit 967c74b4e0d47a4d94236e4de0231dc3db337f6b Merge: f80fa121696 f280c78cb20 Author: CyrusNajmabadi <cyrus.najmabadi@gmail.com> Date: Mon Feb 15 11:35:47 2021 -0800 Merge pull request #51230 from MaStr11/IntPtrRedundantNestedCast2 IDE0004 Redundant cast: False positive for IntPtr -> nint -> int commit f80fa121696086a892997d9d24c02061abf9b665 Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Date: Mon Feb 15 14:35:06 2021 +0000 Update dependencies from https://github.com/dotnet/roslyn build 20210213.12 (#51231) [master] Update dependencies from dotnet/roslyn commit f280c78cb2087fc1f1e99408447684497eba35a9 Author: Martin Strecker <MaStr11@users.noreply.github.com> Date: Mon Feb 15 11:28:45 2021 +0000 Simplify expression check commit 25e740e13f45f52e0bb7375024d07a08c7d5e53d Author: Youssef Victor <youssefvictor00@gmail.com> Date: Mon Feb 15 13:09:26 2021 +0200 Fix test commit ce53c66ef1e39079a2403f4b4479c304cbbf68d1 Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Sun Feb 14 12:12:32 2021 -0800 Switch back to the UI thread. commit a2c5ca4c48fa5f0bfe1313a06fe0005cb60af573 Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Sun Feb 14 01:45:25 2021 -0800 Async service provider. commit 52039d9e0de41ddf69f204b6cb29be2b487b01fc Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Sun Feb 14 01:36:33 2021 -0800 Async service provider. commit 766fab93300319ca7df4793fb49944ec68d52991 Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Sun Feb 14 01:32:01 2021 -0800 Use CT.None commit d043723d1d4ade3b8d63c3a988454bdd5d33c368 Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Sun Feb 14 01:29:44 2021 -0800 Use CT.None commit 07d21830cbeb81ccdfc0fd9ae83263c35ddb7ec6 Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Sun Feb 14 01:25:22 2021 -0800 Switch to ValueTask commit c31c9357f5d3bd192479d59624cab7d7baf6b692 Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Sun Feb 14 00:23:39 2021 -0800 reentrancy' commit 04fa8d3428074721e9ac19ad9a6e551359a0480b Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Sat Feb 13 21:45:30 2021 -0800 null check commit 5add6897e0f074691ab65300330d9aa6a8a43ffc Author: Tomáš Matoušek <tmat@users.noreply.github.com> Date: Sat Feb 13 18:00:09 2021 -0800 Remove dependency on WPF from InteractiveWorkspace logic (#49601) * Remove CSharpInteractiveEvaluator * Move SendToInteractiveSubmissionProvider to EditorFeatures * Remove IScriptEnvironmentService. Fixes #45490 * Make props private * Fix CanExecuteCode * InteractiveSession * Remove IW dependencies * Move InteractiveWorkspace to EditorFeatures * Cleanup completion #r, #load providers * Move completion providers to C# EditorFeatures * Delete Microsoft.CodeAnalysis.CSharp.EditorFeatures.Wpf * Move directive completion providers to Features * Add back command completion * Fix path completion provider * Initialize InteractiveWorkspace with solution analyzer references * Rename InteractiveEvaluator * Better error reporting in interactive integration tests. * SolutionAnalyzerSetter commit 173f96f2cfeb3030b83120fe6819e84cf8282f47 Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Sat Feb 13 11:48:06 2021 -0800 more async commit d3f9833d253de14f394edfe1200c34a2d4ae4a49 Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Sat Feb 13 11:11:41 2021 -0800 Remove methods commit 7179d1a1cc3577f3f3d119033511b499604c1c30 Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Sat Feb 13 11:07:38 2021 -0800 Add comment commit 7cd7d8474b719204f103c2a3eebb80a16c39bc11 Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Sat Feb 13 11:05:38 2021 -0800 Update comment commit fd039ca918dc17a9b3b863b23f65c19d7f6a9e06 Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Sat Feb 13 11:04:48 2021 -0800 Updatecomment commit fb0c5dd3b566187d65a29a84d103bd0b07f3e931 Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Sat Feb 13 11:03:43 2021 -0800 Inline commit 20670a5c850c5b3c89aca5cd83bebf498b1763bb Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Sat Feb 13 11:00:34 2021 -0800 pull solution code up commit 82409beb91592f32e631dfcb43c3ee6a7ce9acd3 Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Sat Feb 13 10:45:06 2021 -0800 More async commit d46ea35a81e3a0ff02253140515b7eed8eb8fa9d Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Sat Feb 13 10:40:48 2021 -0800 Add comment commit 392393a628834c3a3c43695f9ca4de1070ca192e Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Sat Feb 13 10:39:27 2021 -0800 Switch to async loading. commit 539dded87a7eb730f1fc626f398f035d4d72f94c Merge: 5b7bea8b85c b2fd546405d Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Sat Feb 13 10:32:15 2021 -0800 Merge remote-tracking branch 'upstream/master' into asyncProjectFactory commit b2fd546405dcc780781d30adbf122a8ebe34c321 Merge: 6e4fb9bcc59 ea0378caa4c Author: CyrusNajmabadi <cyrus.najmabadi@gmail.com> Date: Sat Feb 13 08:50:04 2021 -0800 Merge pull request #51209 from MaStr11/IntPtrRedundantNestedCast IDE0004 Redundant cast: False positive for IntPtr -> nint -> int commit ea0378caa4c66a57bf40d75e8d1d755a173e2dac Author: Martin Strecker <MaStr11@users.noreply.github.com> Date: Sat Feb 13 14:13:06 2021 +0000 Add numeric types as parentCastType commit 3291f2aa2753f1f28ba907b53a28e878eaf12b45 Author: Martin Strecker <MaStr11@users.noreply.github.com> Date: Sat Feb 13 13:09:45 2021 +0000 Add test case commit 6e4fb9bcc59b43f3192523e0483db31fb5546350 Merge: fdfdcf409b4 0f5cbb5650c Author: CyrusNajmabadi <cyrus.najmabadi@gmail.com> Date: Sat Feb 13 00:41:21 2021 -0800 Merge pull request #51019 from CyrusNajmabadi/unrootedSymbols2 Only compute the unrooted symbol set for FinalState. commit 93d46ecad6a0eedad15df2b6fe7e9a9377081583 Author: Jason Malinowski <jason.malinowski@microsoft.com> Date: Thu Jan 28 16:18:26 2021 -0800 Clean up VisualStudioSymbolNavigationService Oddly, this service wanted to acquire an IThreadingContext, but rather than MEF importing that type directly, it MEF imported the concrete VisualStudio14StructureTaggerProvider and grabbed it's property. That makes no sense. While I'm here, also remove the service factory -- there's no point in making a service factory if you are a singleton with no other state; you can just export yourself directly in that case. commit 02ce81a4a4c3dcb6d67de12fec684a9bd1aeb5f6 Author: Jason Malinowski <jason.malinowski@microsoft.com> Date: Thu Jan 28 15:56:06 2021 -0800 Move the AbstractStructureTaggerProvider down to EditorFeatures This consolidates the implementation between .Cocoa and .Wpf. commit 9d862ffeb99d8e4f6c58a5a5f86562fc42d22c31 Author: Jason Malinowski <jason.malinowski@microsoft.com> Date: Thu Jan 28 15:49:14 2021 -0800 Remove unused code for showing views in outlines in VS for Mac Keeping this as a separate commit from a larger refactoring so we can restore this later. commit fdfdcf409b48c140411e4d15949282cef58c3bdc Author: AlekseyTs <AlekseyTs@users.noreply.github.com> Date: Fri Feb 12 16:16:52 2021 -0800 Enable EndToEndTests. (#51203) Closes #51196. commit 0f5cbb5650c2cd1e67c5da2cea29ade20e86146e Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Fri Feb 12 15:52:34 2021 -0800 Switch to a factory commit 7a32c765017cfbe0f9484e0b11b5d2f70943e409 Author: Fred Silberberg <frsilb@microsoft.com> Date: Fri Feb 12 15:51:57 2021 -0800 Restructure conditional access handling in the control flow graph (#51032) commit 5d12efb23e90bdc062b20852027cb218bca030fa Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Fri Feb 12 15:46:57 2021 -0800 Add assert commit 2f4d924cfd9e1604a81cc0d690bb3f5a4bf1b3ae Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Fri Feb 12 15:45:47 2021 -0800 Strengthen comment commit 26c4f98ae1b831ea41c88a9e9d371a754f767f3e Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Fri Feb 12 15:44:13 2021 -0800 Simplify commit a8b9fd8c4b2da8c7da6fd2bd3ea414ab4966f3bd Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Fri Feb 12 15:43:41 2021 -0800 Make non-nullable commit 54fc0cc69fecf7ee4831db0153332cb0fda452fd Merge: f1c14b0b0c9 7d3f07cc2a4 Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Fri Feb 12 15:41:18 2021 -0800 Merge remote-tracking branch 'upstream/master' into unrootedSymbols2 commit a611e223db168b7e0b3b9973a0b6191e74006362 Merge: 64d1beefeca 75c74ccb49b Author: msftbot[bot] <48340428+msftbot[bot]@users.noreply.github.com> Date: Fri Feb 12 20:54:42 2021 +0000 Merge pull request #51184 from dotnet/merges/release/dev16.9-to-master Merge release/dev16.9 to master commit 64d1beefeca4a0f869cc8fb14fc903af676dcbe4 Merge: fb89a5d6fbd fa751a9075b Author: msftbot[bot] <48340428+msftbot[bot]@users.noreply.github.com> Date: Fri Feb 12 20:44:51 2021 +0000 Merge pull request #51197 from AlekseyTs/master Merge features/UsedAssemblyReferences into 'master' commit fb89a5d6fbd0fc0071ffccd1a23ce600c1faa11d Merge: 7d3f07cc2a4 823f16e2c1b Author: Jason Malinowski <jason.malinowski@microsoft.com> Date: Fri Feb 12 11:44:36 2021 -0800 Merge pull request #50950 from jasonmalinowski/clean-up-editor-features-suggested-actions Unify EditorFeatures.Cocoa/Wpf suggested actions code commit 75c74ccb49bd9b28b3ec6951784c923793dafe6a Merge: 7d3f07cc2a4 70821a70d05 Author: Jason Malinowski <jason.malinowski@microsoft.com> Date: Fri Feb 12 11:35:36 2021 -0800 Merge branch 'release/dev16.9' into master commit fa751a9075bbf0898fbf6952f06ee8e3d90e7420 Author: AlekseyTs <alekseyt@microsoft.com> Date: Fri Feb 12 11:27:20 2021 -0800 Remove prototype comments commit 9d16f637dcf3330481192e46c3c2b96834589468 Merge: af6a45ba74a c1d8c6d0227 Author: msftbot[bot] <48340428+msftbot[bot]@users.noreply.github.com> Date: Fri Feb 12 18:14:30 2021 +0000 Merge pull request #51190 from dotnet/merges/master-to-features/UsedAssemblyReferences Merge 'master' into features/UsedAssemblyReferences commit af6a45ba74a7b6be5717def2d29d2662e772d5ab Author: AlekseyTs <AlekseyTs@users.noreply.github.com> Date: Fri Feb 12 09:11:00 2021 -0800 Fix a regression. (#51188) Clloses https://github.com/dotnet/roslyn-analyzers/issues/4839. commit c1d8c6d0227d75715dce6692f74892a120f5e8e4 Merge: d1af2294379 7d3f07cc2a4 Author: AlekseyTs <alekseyt@microsoft.com> Date: Fri Feb 12 08:27:38 2021 -0800 Merge 'master' into features/UsedAssemblyReferences commit 91f381a1795dab08dcd5d137c624aa90080ca026 Merge: 06a7b7794cf d1af2294379 Author: msftbot[bot] <48340428+msftbot[bot]@users.noreply.github.com> Date: Fri Feb 12 02:50:25 2021 +0000 Merge pull request #51173 from dotnet/merges/master-to-features/UsedAssemblyReferences Merge master to features/UsedAssemblyReferences commit 7d3f07cc2a4c96c217f32b214f7ccbdc91759196 Merge: 0aa332fab4e 14973496642 Author: msftbot[bot] <48340428+msftbot[bot]@users.noreply.github.com> Date: Fri Feb 12 01:26:30 2021 +0000 Merge pull request #51167 from CyrusNajmabadi/sqliteAuthoring Update authoring for sqlitepcl 2.0.4 commit d1af2294379c4245e2d13670052ee82fbaaaeef2 Author: AlekseyTs <alekseyt@microsoft.com> Date: Thu Feb 11 17:04:20 2021 -0800 Fix formatting after merge from master commit 0aa332fab4eae3fd89a80ededc68940d205fc594 Merge: 19757aa26e0 dfd96500f14 Author: msftbot[bot] <48340428+msftbot[bot]@users.noreply.github.com> Date: Fri Feb 12 00:43:54 2021 +0000 Merge pull request #51170 from dotnet/merges/release/dev16.9-to-master Merge release/dev16.9 to master commit 70821a70d0568870cdeb2d269bdb60b0195b9094 Merge: dfd96500f14 2f3bc1a0201 Author: msftbot[bot] <48340428+msftbot[bot]@users.noreply.github.com> Date: Fri Feb 12 00:34:47 2021 +0000 Merge pull request #51175 from JoeRobich/backport-msbuildworkspace-fix Make msbuild workspace test conditional on VS16.9 Preview 3 commit 5b7bea8b85c7ece1adef581ae4e3559a4a23fc6d Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Thu Feb 11 16:22:06 2021 -0800 Fix tests commit 149734966425a132e4625b39cc65ca1b6e7cf8af Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Thu Feb 11 16:10:13 2021 -0800 Update tests commit 96d332f2a29a308f6ae6f9e99f31a7ab6d6814c4 Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Thu Feb 11 16:08:26 2021 -0800 Add signing commit aab8fea441243aed50e023c15890c1eec7c57fce Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Thu Feb 11 16:07:10 2021 -0800 Remove LoadLibrary commit f182ee8dc46525d757cafdda519ea3fd26e5e029 Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Thu Feb 11 16:06:56 2021 -0800 Author according to sam. commit 19757aa26e0148472f18c99873f507358801b6b3 Merge: 26c6d1429ae 57b02478c06 Author: msftbot[bot] <48340428+msftbot[bot]@users.noreply.github.com> Date: Thu Feb 11 23:41:50 2021 +0000 Merge pull request #51163 from CyrusNajmabadi/sharedMemDB Add database path to connection string for shared-memory correctness commit 70c438cd41770656562c4024a5f3488602e551f6 Author: AlekseyTs <alekseyt@microsoft.com> Date: Thu Feb 11 15:26:35 2021 -0800 Fix formatting after merge from master commit 2f3bc1a0201d3ce53e5b7048d92b484d47eb3225 Author: Joey Robichaud <joseph.robichaud@microsoft.com> Date: Thu Feb 11 15:12:00 2021 -0800 Make msbuild workspace test conditional on VS16.9 Preview 3 commit 1031d1aaff6bcd2f900efb60e3a6bd478ea164fb Author: AlekseyTs <alekseyt@microsoft.com> Date: Thu Feb 11 14:49:02 2021 -0800 Temporarily disable some asserts for fields in tuple types declared in source. commit 9f94ccfd67c2f5c9669fd5d74d1056e48576a511 Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Thu Feb 11 14:37:25 2021 -0800 Tweak commit 57b02478c06990805e92bfa8dd463630a0ef60e0 Author: CyrusNajmabadi <cyrus.najmabadi@gmail.com> Date: Thu Feb 11 14:34:50 2021 -0800 Update SqlStatement.cs commit 26c6d1429aec9d9a4330412b9faa9ae7c45a1745 Merge: 5543de28616 1ac01ac1695 Author: Jonathon Marolf <jmarolf@users.noreply.github.com> Date: Thu Feb 11 14:27:20 2021 -0800 Merge pull request #51162 from jmarolf/infrastructure/one-mef-to-rule-them-all lock down the MEF types that we can commit 5543de286164d7d7fd9cc82160527a898eba49aa Merge: b549809eec5 ca90d453270 Author: msftbot[bot] <48340428+msftbot[bot]@users.noreply.github.com> Date: Thu Feb 11 22:21:44 2021 +0000 Merge pull request #51086 from davidwengier/EnCLocalFunctionsTakeTwo EnC - Add rude edits for local functions attributes and type parameters commit b549809eec5d1f80968f17f98ffa17bbfbe1df7f Author: David Wengier <david.wengier@microsoft.com> Date: Fri Feb 12 09:18:11 2021 +1100 Allow didChange to operate on tracked source text directly (#50929) commit ff5e9519c0f96a70b8fdcd9dcdb1a80564fe487c Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Thu Feb 11 14:03:59 2021 -0800 Fix usings commit fe8ca834f938b5bc4548bed528af24a74148c085 Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Thu Feb 11 14:01:18 2021 -0800 Cancellation commit e4afcbb59048dfc36c084740cb16390ce80bdd21 Merge: 0a8f2b9c988 8c0076d1c59 Author: CyrusNajmabadi <cyrus.najmabadi@gmail.com> Date: Thu Feb 11 13:35:01 2021 -0800 Merge branch 'master' into sharedMemDB commit eb26ee3cd1a65a26bda647685ff3a1624218143b Author: AlekseyTs <alekseyt@microsoft.com> Date: Thu Feb 11 13:32:49 2021 -0800 Follow up on merge from master commit 8c0076d1c597c9068ab022ad78157b05e4b934f7 Merge: a815277b020 fedf4a32f23 Author: msftbot[bot] <48340428+msftbot[bot]@users.noreply.github.com> Date: Thu Feb 11 21:17:41 2021 +0000 Merge pull request #51143 from genlu/SuggestionModeWithDelete Fix suggestion mode when triggered with delete commit d21dafcb3a43a28969669a3589c3db1681bd7c78 Merge: 06a7b7794cf c59d44c20ee Author: AlekseyTs <alekseyt@microsoft.com> Date: Thu Feb 11 13:02:38 2021 -0800 Merge 'master' into merges/master-to-features/UsedAssemblyReferences commit ca90d45327074531947c74020d2b4a6a5b16a334 Author: David Wengier <david.wengier@microsoft.com> Date: Fri Feb 12 08:02:06 2021 +1100 Formatting commit 264678dbf5ead73ecc6abd958dbfb957dd818f47 Author: David Wengier <david.wengier@microsoft.com> Date: Thu Feb 11 15:00:57 2021 +1100 Simplify commit 8117a2fbfde3b06b8d993208cca7930b6373afbd Author: David Wengier <david.wengier@microsoft.com> Date: Wed Feb 10 16:33:56 2021 +1100 Add tests for local function type parameters commit 218323767362c0ee217ff0057b68f66eaca45e0d Author: David Wengier <david.wengier@microsoft.com> Date: Tue Feb 9 22:22:21 2021 +1100 Remove assert Now that tree edits are computed for statement syntax, there is no guarantee nodes will be labelled commit 4e2e25cf5a17e37f6372471ac684496d32e841a1 Author: David Wengier <david.wengier@microsoft.com> Date: Tue Feb 9 22:21:53 2021 +1100 Change assert to if, now that more nodes are included in matches commit 156b709d26b1e5d0b24bce8be8a75319e29221e3 Author: David Wengier <david.wengier@microsoft.com> Date: Tue Feb 9 22:21:29 2021 +1100 Don't throw on unexpected nodes in statement syntax edits commit be47ebe0bac4b7a5ae14783690fc4cbb5b11f578 Author: David Wengier <david.wengier@microsoft.com> Date: Tue Feb 9 22:20:53 2021 +1100 Allow parameter updates for statement syntax commit 6283cb8d943ec2aa261c25b88dbe1bfe3a2b4ac0 Author: David Wengier <david.wengier@microsoft.com> Date: Tue Feb 9 22:20:13 2021 +1100 Allow local functions to be moved commit 85fd4d1ab2ea200d439841a66f3e55c33cb9cb5d Author: David Wengier <david.wengier@microsoft.com> Date: Tue Feb 9 22:19:56 2021 +1100 Use the EditClassifier for local functions commit 650609c9cc1a46d644f95b4513a7c0a7511f1d81 Author: David Wengier <david.wengier@microsoft.com> Date: Tue Feb 9 22:19:22 2021 +1100 Fix diagnostic spans for attributes commit 9f8efb510e8fddb7dec305c44f886820c50ae98d Author: David Wengier <david.wengier@microsoft.com> Date: Tue Feb 9 22:18:48 2021 +1100 Fix spans for lambda parameters commit c433337d2664db35902fe86c2eec27444270a2b7 Author: David Wengier <david.wengier@microsoft.com> Date: Tue Feb 9 22:18:29 2021 +1100 Add method to report location function rude edits from syntax commit 8f9780e5c4d56906f30a84da8bdcaf592996ba11 Author: David Wengier <david.wengier@microsoft.com> Date: Tue Feb 9 22:17:59 2021 +1100 Compute distance for local functions and their children commit 57db3535f1bc30dfa4068bb0b3091f55fff34cf0 Author: David Wengier <david.wengier@microsoft.com> Date: Tue Feb 9 22:17:38 2021 +1100 Move parameters and parameter lists from being top level only, to also be statement commit 0be6f6ce5e3cc5b4ea2973bd4f9c908184926903 Author: David Wengier <david.wengier@microsoft.com> Date: Tue Feb 9 22:16:48 2021 +1100 Specify root children of local functions directly commit 94f370810c17f76895f60e575bb8ef2b7e3c035a Author: David Wengier <david.wengier@microsoft.com> Date: Mon Dec 21 10:41:33 2020 +1100 Update statement matching tests for new matched spans commit 7d8768c1bf7d1f94762a57e1e72ee93c4f97abf7 Author: David Wengier <david.wengier@microsoft.com> Date: Mon Dec 21 10:24:36 2020 +1100 Update statement editing tests for new edits commit 8a6ac7d5629e283b361dad9ae3c67250ef7e41ba Author: David Wengier <david.wengier@microsoft.com> Date: Mon Feb 8 13:45:09 2021 +1100 Add failing tests for local function attributes commit a815277b020dcdbb2db242d4a6fe6d98ffa8f117 Author: David Wengier <david.wengier@microsoft.com> Date: Fri Feb 12 07:52:50 2021 +1100 Combine StatementSyntaxComparer and TopSyntaxComparer together (#51021) Co-authored-by: tmat <tomas.matousek@microsoft.com> commit 19a9b62979862a827cc193df355aed0d1c813152 Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Thu Feb 11 12:16:02 2021 -0800 Add transitive dep to try to get it into the authoring properly commit dfd96500f14dbbbc0c323ef38012f38323c86739 Author: Julien Couvreur <jcouv@users.noreply.github.com> Date: Thu Feb 11 12:09:41 2021 -0800 Include WithEvents backing fields into ref assemblies (#50930) commit c59d44c20ee028d261749a14fa2ed78b7559eb40 Merge: 47d000fbd80 d3d225d32ca Author: msftbot[bot] <48340428+msftbot[bot]@users.noreply.github.com> Date: Thu Feb 11 19:44:31 2021 +0000 Merge pull request #51111 from CyrusNajmabadi/spanalloc Allocate some sqlite strings on the stack to avoid causing gc pressure generating them. commit 47d000fbd80cdf5ba5b1bf46623fbb48acb8bc2e Merge: affc43612b8 49e3db353d7 Author: Allison Chou <allichou@microsoft.com> Date: Thu Feb 11 11:34:33 2021 -0800 Merge pull request #51105 from allisonchou/LSPSemanticTokensNoMultiLine [LSP] Split multi-line semantic tokens into single-line tokens commit 67c6bed1581a0d5db35b7e68d6766560a089ea1a Author: Charles Stoner <chucks@microsoft.com> Date: Thu Feb 11 11:15:13 2021 -0800 Only use conditional expression conversion when no common type (#50755) commit cdf3f835c415ef4ca688820c1893d0f38c9e7f01 Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Thu Feb 11 11:08:12 2021 -0800 More JTF commit 88a65984c98aeceaab95fbf8c69305a55addc07d Merge: 2171687fdcf affc43612b8 Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Thu Feb 11 10:46:32 2021 -0800 Merge remote-tracking branch 'upstream/master' into asyncProjectFactory commit 0a8f2b9c988fe703b74195237cec6b64d0154f37 Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Thu Feb 11 10:42:52 2021 -0800 Add database path to connection string for shared-memory correctness commit affc43612b8253fba9296b3c65deb4a78acf0498 Merge: 20974393f6f a734803e97c Author: msftbot[bot] <48340428+msftbot[bot]@users.noreply.github.com> Date: Thu Feb 11 18:40:04 2021 +0000 Merge pull request #51155 from tmat/WorkaroundFor47341 EnC: Avoid NRE due to non-C#/VB documents not serialized to remote workspace commit 40337cc6cd66e3c2e7006d3c5f5dc5d03a40bcf5 Merge: 394b43bf672 e5e8f0ca68c Author: Jason Malinowski <jason.malinowski@microsoft.com> Date: Thu Feb 11 10:36:24 2021 -0800 Merge pull request #50974 from jasonmalinowski/fix-source-generator-multi-targeting-handling Fix source generator multi-targeting handling commit 20974393f6fec2bbf4c065bbfcdcca3e9c1ba637 Author: N. Taylor Mullen <nimullen@microsoft.com> Date: Wed Feb 10 13:01:20 2021 -0800 Run dotnet build Roslyn.sln /t:UpdateXlf commit 3d3e8fa445d68026c4c355918b381c5247b98b77 Author: N. Taylor Mullen <nimullen@microsoft.com> Date: Wed Feb 10 13:00:55 2021 -0800 Don't localize C#, LiveShare or XAML language server names. commit b4ffa289bbfd1cb3ebf312266730395ba7e93354 Author: N. Taylor Mullen <nimullen@microsoft.com> Date: Wed Feb 10 11:26:17 2021 -0800 Do not localize Razor C# LanguageServer. - I imagine you wouldn't want to localize all of the other language clients but didn't want to make the changes there under an assumption. Part of dotnet/aspnetcore#29619 commit d3d225d32caf7a18be5475d45da83309a05b3c91 Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Thu Feb 11 10:29:43 2021 -0800 Add link commit 81f4ce68c98cfdbad5aa8b60f58e4e41c8fc3ef2 Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Thu Feb 11 10:19:51 2021 -0800 lint commit fedf4a32f23cc2a7c6a0c42ca1d8e93999867530 Author: Gen Lu <gel@microsoft.com> Date: Thu Feb 11 10:15:44 2021 -0800 fix tests commit 12e615d6714f895bbc38e668b8a3fa94cb10605b Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Thu Feb 11 10:10:40 2021 -0800 Skip large strings commit 1ac01ac1695b7d77f9005166530f41648aa6a9e3 Author: Jonathon Marolf <jmarolf@microsoft.com> Date: Thu Feb 11 10:02:03 2021 -0800 lock down the MEF types that we can commit 2171687fdcf952a94419457c1883f204961b2240 Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Thu Feb 11 09:19:15 2021 -0800 Update tesst commit a734803e97cdecc5462a735417f1a5af80ea2bbc Author: tmat <tomas.matousek@microsoft.com> Date: Thu Feb 11 09:18:53 2021 -0800 EnC: Avoid NRE due to non-C#/VB documents not serialized to remote workspace commit 259438603af8a6049976fd803d7402ead623827c Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Date: Thu Feb 11 14:46:49 2021 +0000 Update dependencies from https://github.com/dotnet/arcade build 20210210.10 (#51150) [master] Update dependencies from dotnet/arcade commit e7cd1aa374addf4ee7ab9b10118abaa2cca721f3 Merge: 99b6c18e20f 8d1a2f223ac Author: msftbot[bot] <48340428+msftbot[bot]@users.noreply.github.com> Date: Thu Feb 11 06:00:05 2021 +0000 Merge pull request #51128 from JoeRobich/sign-new-dependency Add SQLitePCLRaw.nativelibrary.dll to signing props commit 8a68325dfe47773b5e1fde382bee385a9ba04cf6 Author: CyrusNajmabadi <cyrus.najmabadi@gmail.com> Date: Wed Feb 10 21:58:34 2021 -0800 Update src/Workspaces/Core/Portable/Storage/SQLite/Interop/NativeMethods.cs Co-authored-by: Sam Harwell <sam@tunnelvisionlabs.com> commit 99b6c18e20f4407ef306d5a700b8ea898f1795b0 Author: Charles Stoner <chucks@microsoft.com> Date: Wed Feb 10 21:51:00 2021 -0800 Reduce stack size of BindLeftOfPotentialColorColorMemberAccess (#51141) commit 01fed64c4b02e2535b1e99e4fc01b4235b2747dc Author: Sam Harwell <Sam.Harwell@microsoft.com> Date: Wed Feb 10 21:22:27 2021 -0800 Update code style based on feedback commit d9d398a95a55d1a912b30b2566ef4b219f968653 Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Wed Feb 10 19:53:59 2021 -0800 No need for trailing zero commit cb6e4387d6520de9a93a8fbe95a7f683fd666569 Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Wed Feb 10 19:07:52 2021 -0800 Add comment commit 7b1087a25c9b8566cddb7800ed3b12fe94817fc3 Author: Rikki Gibson <rigibson@microsoft.com> Date: Wed Feb 10 18:59:42 2021 -0800 Walk unit directories in parallel in PrepareTests (#51039) * Walk unit directories in parallel * Update MinimizeUtil.cs * Reduce suspicion * Update src/Tools/PrepareTests/MinimizeUtil.cs Co-authored-by: Jared Parsons <jaredpparsons@gmail.com> Co-authored-by: Jared Parsons <jaredpparsons@gmail.com> commit 92fb2c4ec9c32ccc4f4b2d2ae2704eefabea4d5f Merge: 1d18ec91c40 f3d6ea193a5 Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Wed Feb 10 18:13:50 2021 -0800 Merge remote-tracking branch 'upstream/master' into spanalloc commit f3d6ea193a5d978257ecc536b8bef4a7c50de9b1 Merge: 189bc78c36e 8c5269e948c Author: msftbot[bot] <48340428+msftbot[bot]@users.noreply.github.com> Date: Thu Feb 11 01:51:50 2021 +0000 Merge pull request #51137 from genlu/ushort Deprioritize ushort in completion commit 8c5269e948c7a10e128cc4c62c2ebcc368736444 Author: Gen Lu <gel@microsoft.com> Date: Wed Feb 10 16:46:47 2021 -0800 address review comment commit f1a73ad15b243f282bbb84874c0bf56f49ce29fc Author: Gen Lu <gel@microsoft.com> Date: Wed Feb 10 16:41:25 2021 -0800 Fix suggestion mode when triggered with delete commit 189bc78c36e58ef4620f020722ae80a1ccd729a9 Author: AlekseyTs <AlekseyTs@users.noreply.github.com> Date: Wed Feb 10 16:08:20 2021 -0800 Report use-site diagnostics for overridden/implemented accessors. (#51083) Fixes #50327. commit 29bb62beaa6ac605340070a9aa4a9170e0ffc193 Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Wed Feb 10 15:54:58 2021 -0800 Expose async entrypoint for IWorkspaceProjectContextFactory commit 664ee99951c40d7bb72ee5482b75efd5599fefb7 Author: Gen Lu <gel@microsoft.com> Date: Wed Feb 10 15:54:33 2021 -0800 Fix merge issue commit 90deddb5b1cd029400c43bb37f8c86b797f865eb Merge: bfc33c58592 b4790f994b7 Author: Gen Lu <gel@microsoft.com> Date: Wed Feb 10 15:51:32 2021 -0800 Merge remote-tracking branch 'dotnet/master' into ushort commit bfc33c585923bd013737fc37b8ebdb1b1ad4abda Author: Gen Lu <gel@microsoft.com> Date: Wed Feb 10 15:13:17 2021 -0800 Deprioritize ushort in compeltion commit b4790f994b70cd45716d4615b0e98c5d2ea5cea3 Author: Jared Parsons <jaredpparsons@gmail.com> Date: Wed Feb 10 15:41:23 2021 -0800 Regression test (#51121) closes #33295 commit d8a22e5b458cf71f079fd1512e743d813b36c09d Author: Julien Couvreur <jcouv@users.noreply.github.com> Date: Wed Feb 10 15:23:20 2021 -0800 Analyze properties with conditional attributes in patterns (#51001) commit 09c18810e96b0aea606310c4b99585918b0860b4 Merge: a19f4eb28bc 7ab8b99112b Author: CyrusNajmabadi <cyrus.najmabadi@gmail.com> Date: Wed Feb 10 14:22:49 2021 -0800 Merge pull request #50358 from CyrusNajmabadi/experimentalFormatting Port roslyn-analyer style rules to experimental rules in roslyn. commit a19f4eb28bcc172945f868dae6d9753ea1fc070c Merge: a7db2a1e0c6 a5f69c21001 Author: Shen Chen <Cosifne@users.noreply.github.com> Date: Wed Feb 10 14:03:01 2021 -0800 Merge pull request #51098 from dotnet/dev/shech/SwitchBuildPool Change micro build pool commit a7db2a1e0c6db4750ce5f24b8c64b7b23d94b2f0 Merge: 6b83878bc22 394b43bf672 Author: Joey Robichaud <jorobich@microsoft.com> Date: Wed Feb 10 13:11:31 2021 -0800 Merge pull request #51114 from dotnet/merges/release/dev16.9-to-master Merge release/dev16.9 to master commit 7ab8b99112bf0ac95294d6aa15f0b8b9a1b7968e Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Wed Feb 10 12:57:10 2021 -0800 Fix tests commit 06a7b7794cffeb222b5692fc7eaa64761ef4954b Merge: dd7fadb2d66 473155a306c Author: Joey Robichaud <jorobich@microsoft.com> Date: Wed Feb 10 12:53:47 2021 -0800 Merge pull request #49862 from JoeRobich/add-unusedreference-dialog Add Remove Unused References dialog commit 8d1a2f223ac2f09b20274d5dc51b344c26a9233a Author: Joey Robichaud <jorobich@microsoft.com> Date: Wed Feb 10 12:28:29 2021 -0800 Add SQLitePCLRaw.nativelibrary.dll to signing props commit 49e3db353d738f0d856d1a593583ffc95e009258 Author: Allison Chou <allichou@microsoft.com> Date: Wed Feb 10 12:03:37 2021 -0800 Make assert failure message more detailed commit a31df02383554751d8ab7767c5a2e58425443f9f Merge: 00e925dd142 b70814c4991 Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Wed Feb 10 11:43:14 2021 -0800 Merge branch 'experimentalFormatting' of https://github.com/CyrusNajmabadi/roslyn into experimentalFormatting commit 00e925dd142ade0c1c344b8d2874aeb31671d2d3 Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Wed Feb 10 11:29:29 2021 -0800 Fix tests commit 473155a306c430a9a585f48d1c3fe39bc818a261 Author: Joey Robichaud <joseph.robichaud@microsoft.com> Date: Wed Feb 10 10:40:37 2021 -0800 Fix formatting commit 235c04505ff5e6d87b6c589e949b2d7ed9f89dbe Author: Joey Robichaud <joseph.robichaud@microsoft.com> Date: Wed Feb 10 10:02:58 2021 -0800 Fix test for new 2 pass behavior commit cb8ce7b01db6d7a6a68f2c9747b61f730b0d337e Author: Allison Chou <allichou@microsoft.com> Date: Tue Feb 9 23:37:30 2021 -0800 Address code review feedback commit a8868362c3b5bbbae10d89081a7e11d89d742010 Author: Joey Robichaud <joseph.robichaud@microsoft.com> Date: Tue Feb 9 23:26:28 2021 -0800 Add missing paren commit b4a71c30c6aa5e441d57b5038cd5ef581eb7e12a Author: Joey Robichaud <joseph.robichaud@microsoft.com> Date: Tue Feb 9 21:26:03 2021 -0800 Be defensive about potentially removed projects commit 63c782e3ca932f5664e8f015b6078874c3b2d6bb Author: Joey Robichaud <joseph.robichaud@microsoft.com> Date: Tue Feb 9 21:25:33 2021 -0800 Don't remove table entries in the Dispose() call. commit 772a24af566961b07c13e78e7b0e7716186a911b Author: Joey Robichaud <joseph.robichaud@microsoft.com> Date: Tue Feb 9 21:25:00 2021 -0800 Ensure we cleanup table data after showing dialog commit 1e744b4882b26e6bb1cfc330dac64b2dbd6dda34 Author: Joey Robichaud <joseph.robichaud@microsoft.com> Date: Tue Feb 9 21:24:28 2021 -0800 Remove argument to IsBuildActive commit 292bb6eb09e2896aee13bf13d833dd6e5c6a07cc Author: Joey Robichaud <joseph.robichaud@microsoft.com> Date: Tue Feb 9 21:23:33 2021 -0800 Use WhereNotNull() instread of OfType<>() commit 6b5efb62cfe8e7482f7945893aaf509660626c69 Author: Joey Robichaud <joseph.robichaud@microsoft.com> Date: Tue Feb 9 21:21:23 2021 -0800 Rename UnusedReferencesService to UnusedReferencesRemover commit 03f3b2337390efa85ce371086b246da872135845 Author: Joey Robichaud <joseph.robichaud@microsoft.com> Date: Tue Feb 9 21:19:24 2021 -0800 Add an experiment to dogfood remove unused references commit 1115ec9f914071167a92599ad399fe7ce8f4c19b Merge: 3c00635e0bd dd7fadb2d66 Author: Joey Robichaud <joseph.robichaud@microsoft.com> Date: Tue Feb 9 21:32:23 2021 -0800 Merge remote-tracking branch 'origin/features/UsedAssemblyReferences' into add-unusedreference-dialog commit 394b43bf6720c8a1a6e9abe6b8f11f3a05d57974 Merge: 93f28f31ea3 c28537561c0 Author: Joey Robichaud <jorobich@microsoft.com> Date: Tue Feb 9 19:27:44 2021 -0800 Merge pull request #51093 from dotnet/feed-update-release/dev16.9 [release/dev16.9] NuGet Feed Update commit 6b83878bc2262c8e7027625f032c76bf791e5444 Merge: 4560d03d429 5acb6f338b4 Author: Joey Robichaud <jorobich@microsoft.com> Date: Tue Feb 9 19:27:17 2021 -0800 Merge pull request #51092 from dotnet/feed-update-master [master] NuGet Feed Update commit b70814c4991e89d896c213a16e27646acb23b062 Merge: 2a81547c320 4560d03d429 Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Tue Feb 9 18:18:25 2021 -0800 Merge remote-tracking branch 'upstream/master' into experimentalFormatting commit 4560d03d429423a05a02a3079baca2ad182062c3 Merge: e05001026d3 5c7f63db140 Author: Allison Chou <allichou@microsoft.com> Date: Tue Feb 9 18:02:08 2021 -0800 Merge pull request #51002 from allisonchou/LSPInvokeKinds [LSP] Make completion triggers more specific commit 1d18ec91c40bba58702d6f4311d8fd90e78557b6 Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Tue Feb 9 17:44:34 2021 -0800 Update length commit 891eb8ab33b7d2d3aacca44e7e9546bc42d28555 Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Tue Feb 9 17:39:15 2021 -0800 REvert commit de769e34286d5ea09b53fb7af60653926cb358df Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Tue Feb 9 17:38:58 2021 -0800 print longest commit 22e223ef09d48ecd4ee5e28f843d00b956fff3d0 Author: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> Date: Tue Feb 9 17:37:17 2021 -0800 Allocate some sqlite strings on the stack to avoid causing gc pressure generating them. commit 2a81547c320d9a1e8a645e67aa369193cf68cf63 Author: CyrusNajmabadi <cyrus.najmabadi@gmail.com> Date: Tue Feb 9 17:36:16 2021 -0800 Update IDEDiagnosticIDConfigurationTests.cs commit e05001026d36da1f4917531c0b344cb497841cc4 Merge: cbc6d2ca6f2 37113c78049 Author: CyrusNajmabadi <cyrus.najmabadi@gmail.com> Date: Tue Feb 9 16:37:15 2021 -0800 Merge pull request #51028 from CyrusNajmabadi/fixParsing Alternate approach to fixing errant :: token commit cbc6d2ca6f297d749203b2b70cdbb38c9c7d66e8 Merge: 4e0d3f0092b 57d9b49fce8 Author: CyrusNajmabadi <cyrus.najmabadi@gmail.com> Date: Tue Feb 9 16:27:35 2021 -0800 Merge pull request #51106 from CyrusNajmabadi/noFetch Do not fetch or populate the string table in bulk. commit 4e0d3f0092bb9e75423398823fbffb0407321df7 Merge: ca867410e18 13417bd63be Author: msftbot[bot] <48340428+msftbot[bot]@users.noreply.github.com> Date: Wed Feb 10 00:20:05 2021 +0000 Merge pull request #51107 from tmat/VisualStudioRemoteHostClientProviderJTF Use VS AsyncLazy, which supports JTF commit ca867410e184fac61c1004bd89e2b09e4bfcd9f8 Merge: 11cc9642b0c 7113c482dc9 Author: msftbot[bot] <48340428+msftbot[bot]@users.noreply.github.com> Date: Wed Feb 10 00:04:21 2021 +0000 Merge pull request #51102 from dotnet/merges/release/dev16.9-to-master Merge release/dev16.9 to master commit 11cc9642b0c9f375b47f5a82bfc3dcbffbdd3caf Author: Martin Streck…

RikkiGibson and others added 6 commits January 4, 2021 17:35

initial commit

3cf2d73

fix

3794254

WIP

d784e62

Fixup for the demo

4fd9f08

Got runfo validating

fce5c72

Demo looking even better

2a5bbda

dotnet-issue-labeler bot added the Area-Infrastructure label Feb 2, 2021

Merge branch 'master' of github.com:dotnet/roslyn into rebuild-roslyn

0b2b376

RikkiGibson force-pushed the rebuild-roslyn branch from a26685b to 71a06e3 Compare February 9, 2021 00:19

RikkiGibson commented Feb 9, 2021

View reviewed changes

RikkiGibson marked this pull request as ready for review February 9, 2021 00:23

RikkiGibson requested review from a team as code owners February 9, 2021 00:23

Rebuild Microsoft.CodeAnalysis

dbc5eba

RikkiGibson force-pushed the rebuild-roslyn branch from 71a06e3 to dbc5eba Compare February 9, 2021 00:44

jaredpar reviewed Feb 9, 2021

View reviewed changes

Address some feedback

3f395ac

RikkiGibson mentioned this pull request Feb 9, 2021

Enable EmbedUntrackedSources throughout Roslyn #51099

Closed

1 task

jaredpar reviewed Feb 9, 2021

View reviewed changes

RikkiGibson added 2 commits February 9, 2021 14:09

Address feedback

85c2a78

Use Exec-Console

642fa3b

ryzngard reviewed Feb 10, 2021

View reviewed changes

jaredpar reviewed Feb 10, 2021

View reviewed changes