Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable EmbedUntrackedSources throughout Roslyn #51099

Closed
1 task
RikkiGibson opened this issue Feb 9, 2021 · 4 comments · Fixed by #53406
Closed
1 task

Enable EmbedUntrackedSources throughout Roslyn #51099

RikkiGibson opened this issue Feb 9, 2021 · 4 comments · Fixed by #53406
Assignees
Labels
Area-Infrastructure New Language Feature - Rebuild Compiler ability to verify provenance of code via rebuild operations

Comments

@RikkiGibson
Copy link
Contributor

RikkiGibson commented Feb 9, 2021

In order to rebuild Roslyn, we need to be able to access sources generated at build time, such as AssemblyInfo.cs, as well as sources produced by source generators like CSharpSyntaxGenerator.



This is a temporary change correct? The idea being that when we are done with this effort that we will be adding this to Directory.Build.props? If so are we tracking that in an issue, comment, etc ...?

Originally posted by @jaredpar in #50968 (comment)

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Feb 9, 2021
@RikkiGibson RikkiGibson self-assigned this Feb 9, 2021
@clairernovotny
Copy link
Member

Does Roslyn use Arcade? I'd expect EmbedUntrackedSources to be enabled by default by the top-level Arcade SDK.

@jaredpar
Copy link
Member

We do use Arcade but we don't use Arcade 5 because it's not LTS. We are still on Arcade 1 (might have been called 3) because it's the only available LTS.

@RikkiGibson
Copy link
Contributor Author

We are still on Arcade 1 (might have been called 3)

Arcade 1.x is what ships in the .NET 3 Eng channel. https://github.com/dotnet/arcade/blob/release/3.x/eng/Versions.props
Arcade 5.x ships in the .NET 5 channel. https://github.com/dotnet/arcade/blob/release/5.0/eng/Versions.props

I imagine the Arcade maintainers decided to make the version align with the .NET version starting with .NET 5.

@jinujoseph jinujoseph removed the untriaged Issues and PRs which have not yet been triaged by a lead label Feb 10, 2021
@RikkiGibson
Copy link
Contributor Author

Depends on #51647

@RikkiGibson RikkiGibson added the New Language Feature - Rebuild Compiler ability to verify provenance of code via rebuild operations label Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure New Language Feature - Rebuild Compiler ability to verify provenance of code via rebuild operations
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants