Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form1.cs doesn't get recognized as designer file for new WinForms .NET Core projects #45471

Closed
Shyam-Gupta opened this issue Jun 26, 2020 · 4 comments
Assignees
Labels
Area-IDE Bug Regression Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented
Milestone

Comments

@Shyam-Gupta
Copy link
Member

Version Used:

VS IntPreview build: 16.7.0 Preview 4.0 [30224.187.master]

Steps to Reproduce:

  1. In latest VS IntPreview build, create a new WinForms .NET Core project.
    (Note that this bug doesn't repro on opening an existing project.)
  2. Notice that Form1.cs opens up in code editor rather than designer
  3. Wait for Form1.cs icon to change to that of a designer

Expected Behavior:
Form1.cs should get recognized as a designer file quickly after a new WinForms .NET Core project gets created.

Actual Behavior:
It takes a lot of time for Form1.cs to get recognized as a WinForms designer file. Sometimes it does not get recognized at all. During this time the user is completely blocked as there is no way to open the designer.

@CyrusNajmabadi
Copy link
Member

I don't repro this on Version 16.7.0 Preview 3.0. We correctly report the designer attribute after a reasonable time. On my machine that's about 15 seconds after project creation. This happens due to us waiting for other work to settle down and for us to enter into our background processing mode.

@kirsan31
Copy link

kirsan31 commented Jul 25, 2020

The problem is in not working mechanics of discovery forms if thy are not in *.csproj.user or the file is absent.
Issue with new project is related to dotnet/winforms#3510
But without *.csproj.user (new project, pull from repo etc...) or if form is absent in it, things are completely broken: dotnet/winforms#3619 (comment).

@jnm2
Copy link
Contributor

jnm2 commented Jul 25, 2020

Yeah, this is taking several minutes for some larger projects after git clean, and other projects never get the icon at all (after leaving it for hours). It doesn't seem consistent. Some projects have issues only half the time after a git clean.

@CyrusNajmabadi
Copy link
Member

We believe this should be fixed for 16.8 with these two PRs:

#46391
#46426

@sharwell sharwell added the Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented label Jul 30, 2020
@sharwell sharwell modified the milestones: 16.7, Next Jul 30, 2020
@RikkiGibson RikkiGibson modified the milestones: Next, 16.8.P2 Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE Bug Regression Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented
Projects
None yet
Development

No branches or pull requests

8 participants